This is an archive of the discontinued LLVM Phabricator instance.

[LTO] Move UpdateCompilerUsed.h from lib/ to include/
ClosedPublic

Authored by davide on Jun 21 2016, 5:11 PM.

Details

Summary

I plan to use it in lld. Are you OK with moving this to include/ , or there's a particular reason why it should stay in lib/LTO?

Thanks!

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 61464.Jun 21 2016, 5:11 PM
davide retitled this revision from to [LTO] Move UpdateCompilerUsed.h from lib/ to include/.
davide updated this object.
davide added reviewers: mehdi_amini, dexonsmith.
davide added a subscriber: llvm-commits.

In particular, this is how I use it: http://reviews.llvm.org/D21577

mehdi_amini accepted this revision.Jun 21 2016, 7:51 PM
mehdi_amini edited edge metadata.

Sure!
(Note: this patch is missing the new header and only shows the removed one)

This revision is now accepted and ready to land.Jun 21 2016, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Thanks Mehdi!
I'm not sure why phab ate the new header file, but I made sure it was committed upstream =)

dexonsmith edited edge metadata.Jun 22 2016, 7:49 AM
dexonsmith added a subscriber: dexonsmith.

I think there is a component on our bugzilla for phabricator bugs. Not sure whether you should file a bug there or on phab's bug tracker, but it's probably worth reporting somehow.

  • dpnes
llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp