This diff encompasses clang support for CSI.
Diff Detail
- Repository
- rL LLVM
Event Timeline
docs/CSI.rst | ||
---|---|---|
7 | The intro paragraph is important to attract users. On the other hand, the intro lacks a single most important sentence, in bold, explaining why CSI is cool. Something like "With CSI the tool writers will not need to hack the compiler" | |
22 | gold is not the only linker that supports LTO. | |
29 | Here you may want a bit more detail. | |
38 | -emit-llvm here is confusing, at least for me. Ideally, this and linking the null tool should be hidden under -fcsi or some such, | |
48 | Even if this is true, the statement is a bit risky. | |
58 | Too complex. Just tell the user that they need to use fresh clang. | |
61 | -emit-llvm again. It should be hidden inside -fcsi. | |
64 | again, gold is not the only LTO-enabled linker. | |
79 | this too needs to be hidden under -fcsi | |
125 | avoid the C preprocessor when you can (const var is usually better) | |
148 | On Linux, there is preinit_array... Just saying... | |
196 | didn't you want properties here? (there are plenty of papers on this, e.g. http://users.sdsc.edu/~mtikir/publications/papers/issta02.pdf) | |
216 | maybe use callee_id instead of func_id? | |
245 | avoid #defines. | |
266 | ask around, and look in other places (esan?) if there is something like this already | |
271 | const char ? | |
294 | or consider lazy initialization. | |
303 | pcc@ wanted to comment on this. | |
312 | Might not? Or will not? | |
include/clang/Basic/LangOptions.def | ||
258 | please use 80 chars per line here and everywhere else. | |
lib/Driver/Tools.cpp | ||
4944 | Most of the LLVM code does not use {} for 1-line statements like this (according to the style guide). |
The intro paragraph is important to attract users.
That's up to you, but I would try to make it shorter.
E.g.
"framework providing comprehensive static instrumentation via the compiler"
might be replaced with
"framework for comprehensive compile-time instrumentation"
etc.
On the other hand, the intro lacks a single most important sentence, in bold, explaining why CSI is cool. Something like "With CSI the tool writers will not need to hack the compiler"