This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][llvm-mc] Predefined symbols to access -mcpu from assembly source (.option.machine_...)
ClosedPublic

Authored by artem.tamazov on Jun 10 2016, 12:58 PM.

Details

Summary

The feature allows for conditional assembly etc.
It is still unclear how to make those symbols read-only.
Test added.

Diff Detail

Repository
rL LLVM

Event Timeline

artem.tamazov retitled this revision from to [AMDGPU][llvm-mc] Predefined symbols to access -mcpu from assembly source (.option.machine_...).
artem.tamazov updated this object.
artem.tamazov added a reviewer: Restricted Project.
artem.tamazov set the repository for this revision to rL LLVM.
artem.tamazov added a project: Restricted Project.

LGTM, except we should expose the proposed symbol names before submitting, there can be other suggestions.

SamWot accepted this revision.Jun 14 2016, 4:56 AM
SamWot added a reviewer: SamWot.
SamWot added a subscriber: SamWot.
SamWot added inline comments.
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
595

Better place this names to AMDGPUAsmUtils

This revision is now accepted and ready to land.Jun 14 2016, 4:56 AM

LGTM, except we should expose the proposed symbol names before submitting, there can be other suggestions.

Suggestions (and subsequent conversations) are good but take time. Let's deliver functionality to our customers without extra delay. We can easy change names to something else, if required. Besides, I've exposed names in the relevant mail thread several days ago, and there is none objections/suggestions))

lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
595

Let's see how code will evolve in time. For now, code almost complies with One Definition Rule, so I would better KISS it. Thanks for reviewing.

This revision was automatically updated to reflect the committed changes.