This is an archive of the discontinued LLVM Phabricator instance.

clang-rename: fix the DynamicCastExpr test on ps4
ClosedPublic

Authored by vmiklos on Jun 9 2016, 9:14 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

vmiklos updated this revision to Diff 60185.Jun 9 2016, 9:14 AM
vmiklos retitled this revision from to clang-rename: mark the DynamicCastExpr test unsupported on ps4.
vmiklos updated this object.
vmiklos added a reviewer: klimek.
vmiklos added a subscriber: cfe-commits.
silvas added a subscriber: silvas.Jun 10 2016, 1:05 AM

It has no RTTI, so the test would always fail in a non-interesting way.

It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You can fix this by explicitly adding -frtti I believe.

It has no RTTI, so the test would always fail in a non-interesting way.

It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You can fix this by explicitly adding -frtti I believe.

Sorry, that was a bit unclear (I thought you meant "it" meaning "this test"). On PS4 RTTI is disabled by default, but -frtti turns it on, so you should be able to add -frtti to this test to fix it.

vmiklos updated this revision to Diff 60320.Jun 10 2016, 1:17 AM
vmiklos retitled this revision from clang-rename: mark the DynamicCastExpr test unsupported on ps4 to clang-rename: fix the DynamicCastExpr test on ps4.
vmiklos updated this object.

Ah, then the fix is simpler, I guess. :-)

vmiklos updated this revision to Diff 60324.Jun 10 2016, 1:20 AM

Correct diff this time.

silvas accepted this revision.Jun 10 2016, 1:28 AM
silvas added a reviewer: silvas.

LGTM

This revision is now accepted and ready to land.Jun 10 2016, 1:28 AM
This revision was automatically updated to reflect the committed changes.