This is an archive of the discontinued LLVM Phabricator instance.

Strip Android version when looking up toolchain paths.
ClosedPublic

Authored by jmgao on Jun 8 2016, 6:16 PM.

Details

Summary

Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21'), used for checking for availability.
However, the driver was searching for toolchain binaries using the
passed in triple as a prefix.

Diff Detail

Repository
rL LLVM

Event Timeline

jmgao updated this revision to Diff 60126.Jun 8 2016, 6:16 PM
jmgao retitled this revision from to Strip Android version when looking up toolchain paths..
jmgao updated this object.
jmgao added reviewers: srhines, danalbert.
jmgao added a subscriber: cfe-commits.

This could do with a test in test/Driver.

jmgao updated this revision to Diff 60294.Jun 9 2016, 6:21 PM

Add test.

t.p.northover accepted this revision.Jun 9 2016, 8:39 PM
t.p.northover added a reviewer: t.p.northover.

I think that looks good. Thanks for adding the test!

Tim.

This revision is now accepted and ready to land.Jun 9 2016, 8:39 PM

Thanks for the review!

This revision was automatically updated to reflect the committed changes.