Do not assume that -fsanitize=address is valid option in clang tests

[christof]

Summary

The asan tests should only run on builds that have LLVM_USE_SANITIZER set. The feature 'asan' reflects this and is required for test/CodeGen/lifetime-asan.c

[kubamracek]

This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing?

[vitalybuka]

I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509

[vitalybuka]

Actually there are other tests with -fsanitize=address
I see only difference in %clang vs %clang_cc1?
Could you try this?

[vitalybuka]

It was accepted accidentally.

[vitalybuka]

Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu

[vitalybuka]

http://reviews.llvm.org/D21117

[christof]

In D21082#451393, @kubabrecka wrote:

This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing?

Right. I was confused about the meaning of that feature. The test fails with:
clang-3.9: error: unsupported option '-fsanitize=address' for target 'aarch64-arm-none-eabi’

The patch suggested by vitalybuka seems to work. So I suggest we go for that.

test/CodeGen/lifetime-asan.c

 // RUN: %clang -S -emit-llvm -o - -O0 %s | FileCheck %s -check-prefix=CHECK-O0
 // RUN: %clang -S -emit-llvm -o - -O0 \
 // RUN:     -fsanitize=address -fsanitize-address-use-after-scope %s | \
 // RUN:     FileCheck %s -check-prefix=CHECK-ASAN-USE-AFTER-SCOPE
+// REQUIRES: asan
 // UNSUPPORTED: mingw32
 
 extern int bar(char *A, int n);
 
 // CHECK-O0-NOT: @llvm.lifetime.start
 int foo(int n) {
   if (n) {
     // CHECK-ASAN-USE-AFTER-SCOPE: @llvm.lifetime.start(i64 10, i8* {{.*}})