This is an archive of the discontinued LLVM Phabricator instance.

Don't remove PIE executables when using svr4 packets
ClosedPublic

Authored by fjricci on Jun 3 2016, 3:15 PM.

Details

Summary

Because PIE executables have an e_type of llvm::ELF::ET_DYN,
they are not of type eTypeExecutable, and were being removed
when svr4 packets were used.

Diff Detail

Event Timeline

fjricci updated this revision to Diff 59632.Jun 3 2016, 3:15 PM
fjricci updated this revision to Diff 59633.
fjricci retitled this revision from to Don't remove PIE executables when using svr4 packets.
fjricci updated this object.
fjricci added reviewers: clayborg, ADodds, tfiala.
fjricci added a subscriber: lldb-commits.

Fix curly-brace style

fjricci updated this revision to Diff 59637.Jun 3 2016, 3:47 PM

Refactor to remove unnecessary object file type checking

tfiala accepted this revision.Jun 4 2016, 10:25 AM
tfiala edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jun 4 2016, 10:25 AM
sas accepted this revision.Jun 4 2016, 6:09 PM
sas added a reviewer: sas.

Nit: Adding a comment explaining why we special-case the main executable (i.e.: because it is never included in libraries-svr4 packets) might be useful here.

This revision was automatically updated to reflect the committed changes.