Page MenuHomePhabricator

ADodds (Aidan Dodds)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 16 2014, 7:43 AM (357 w, 12 h)

Recent Activity

Apr 19 2016

ADodds accepted D19230: Properly unload modules from target image list when using svr4 packets.

Looks fine to me.

Apr 19 2016, 3:44 AM

Feb 26 2016

ADodds accepted D16412: remove unused local string in IRForTarget.cpp.

I'm happy to commit this for you.

Feb 26 2016, 10:05 AM
ADodds accepted D17167: Fix bug with register values byte order in expression evaluation.

I am happy to commit this for you since you have addressed the concerns raised by Sean.

Feb 26 2016, 9:44 AM

Feb 18 2016

ADodds retitled D17395: Refactor GetSoftwareBreakpointTrapOpcode from to Refactor GetSoftwareBreakpointTrapOpcode.
Feb 18 2016, 10:02 AM

Jan 12 2016

ADodds accepted D16004: Increase use of svr4 packets to improve performance on POSIX remotes.

Looks good to me, assuming that Tamas is happy also.

Jan 12 2016, 9:50 AM

Jan 11 2016

ADodds added inline comments to D16004: Increase use of svr4 packets to improve performance on POSIX remotes.
Jan 11 2016, 9:43 AM
ADodds added inline comments to D16004: Increase use of svr4 packets to improve performance on POSIX remotes.
Jan 11 2016, 9:32 AM

Dec 17 2015

ADodds added a comment to D15566: Patch cmake to allow detection of python 2.7.9+.

Its currently present in the official 2.7.10 windows x64 python distro from python.org.

Dec 17 2015, 6:01 AM

Dec 16 2015

ADodds updated D15566: Patch cmake to allow detection of python 2.7.9+.
Dec 16 2015, 5:46 AM
ADodds retitled D15566: Patch cmake to allow detection of python 2.7.9+ from to Patch cmake to allow detection of python 2.7.9+.
Dec 16 2015, 5:41 AM

Dec 9 2015

ADodds added a comment to D15333: Enable half2float() on windows..

If there are no objections, are you happy to accept this?

Dec 9 2015, 9:03 AM
ADodds updated subscribers of D15333: Enable half2float() on windows..
Dec 9 2015, 1:44 AM

Dec 8 2015

ADodds retitled D15333: Enable half2float() on windows. from to Enable half2float() on windows..
Dec 8 2015, 6:19 AM

Nov 13 2015

ADodds retitled D14639: LLDB JIT needs android vector passing rules. from to LLDB JIT needs android vector passing rules..
Nov 13 2015, 2:00 AM

Nov 10 2015

ADodds retitled D14538: Fix DwarfSymbolFile when appending global functions from different modules from to Fix DwarfSymbolFile when appending global functions from different modules.
Nov 10 2015, 4:26 AM

Sep 17 2015

ADodds retitled D12936: Groundwork for better tracking of renderscript allocations and scripts. from to Groundwork for better tracking of renderscript allocations and scripts..
Sep 17 2015, 7:55 AM

Jun 17 2015

ADodds retitled D10499: Fix duplicate shared module list entries from to Fix duplicate shared module list entries.
Jun 17 2015, 3:20 AM

Jun 1 2015

ADodds accepted D9931: Don't close handle returned by _get_osfhandle.

Hi Oleksiy,

Jun 1 2015, 3:36 AM

May 28 2015

ADodds updated the diff for D10062: Fix THUMB mode discovery for LSB-set symbols.

This patch trys to address the issues raised by Tamas. Arm symbols will now also be added to the m_address_class_map too.

May 28 2015, 7:11 AM
ADodds added a comment to D10062: Fix THUMB mode discovery for LSB-set symbols.

You have to add an entry to the m_address_class_map for arm symbols also because with the current change all address treated as thumb when you don't have mapping symbols.

P.S.: Next time please upload the diff with full context

Perhaps I have misunderstood your concern, but the symbol is only marked as eAddressClassCodeAlternateISA if it is THUMB since that happense inside:

if (symbol_type == eSymbolTypeCode && symbol.st_value & 1)

Are you suggesting that I need to add an 'else' to this check and mark it as eAddressClassCode? I can see that would make sense.

Yes, you have to add an entry for arm symbols also because of the way m_address_class_map is used (see ObjectFileELF::GetAddressClass). Basically an entry means that all address have the specified type until the next entry (ordered by address). The reason behind this layout is that you can query the address class of any address without have to resolve it to a symbol it belongs to.

May 28 2015, 2:27 AM
ADodds added a comment to D10062: Fix THUMB mode discovery for LSB-set symbols.

You have to add an entry to the m_address_class_map for arm symbols also because with the current change all address treated as thumb when you don't have mapping symbols.

P.S.: Next time please upload the diff with full context

May 28 2015, 2:10 AM

May 27 2015

ADodds retitled D10062: Fix THUMB mode discovery for LSB-set symbols from to Fix THUMB mode discovery for LSB-set symbols.
May 27 2015, 9:31 AM
ADodds closed D9473: Fix: GdbRemote sends qModuleInfo but ignores unsupported response.

Closed by commit r236486 on 05/05/2015.

May 27 2015, 4:04 AM

May 7 2015

ADodds updated the diff for D9471: Improved LLDB GdbServer support and shared library only debugging.

Hi greg,

May 7 2015, 10:04 AM

May 6 2015

ADodds updated the diff for D9471: Improved LLDB GdbServer support and shared library only debugging.

Hi Greg,

May 6 2015, 10:48 AM

May 5 2015

ADodds added a comment to D9471: Improved LLDB GdbServer support and shared library only debugging.

Hi Greg,
I forgot to remove two changes which accidentally made it threw in this patch. Could you please ignore the changes to PlatformWindows.cpp involving the software breakpoint opcode, and the change to GDBRemoteCommunicationClient.cpp which was committed this morning.
Sorry for the confusion.

May 5 2015, 9:59 AM
ADodds updated the diff for D9471: Improved LLDB GdbServer support and shared library only debugging.

Hi greg, I have pushed the loading code back inside of ProcessGDB remote as you suggested.
I wasnt quite following your suggestion regarding SetExecutable in the PosixDYLD, could you elaborate more on that please.

May 5 2015, 7:36 AM

May 4 2015

ADodds retitled D9473: Fix: GdbRemote sends qModuleInfo but ignores unsupported response from to Fix: GdbRemote sends qModuleInfo but ignores unsupported response.
May 4 2015, 8:11 AM
ADodds retitled D9471: Improved LLDB GdbServer support and shared library only debugging from to Improved LLDB GdbServer support and shared library only debugging.
May 4 2015, 8:01 AM

Apr 15 2015

ADodds updated the diff for D8999: LLDB qXfer:features:read support.

Thanks again Greg.

Apr 15 2015, 10:25 AM

Apr 14 2015

ADodds updated the diff for D8999: LLDB qXfer:features:read support.

Thanks for having a look at my previous patch Greg. I have made a revision that hopefully addresses all the points you had raised earlier. Any other C&C is welcome.

Apr 14 2015, 9:16 AM

Apr 13 2015

ADodds updated the diff for D8999: LLDB qXfer:features:read support.

This change adds support for gdbserver running on android Arm. It also fixes a bug where register discovery would bomb out if the osabi name wasnt given in target.xml. I have moved gdbserver register discovery inside of BuildDynamicRegisterInfo() so it will only be used when registers dont already exist (as intended).

Apr 13 2015, 8:36 AM
ADodds updated D8999: LLDB qXfer:features:read support.
Apr 13 2015, 5:50 AM
ADodds updated D8999: LLDB qXfer:features:read support.
Apr 13 2015, 5:47 AM
ADodds updated D8999: LLDB qXfer:features:read support.
Apr 13 2015, 5:44 AM
ADodds updated D8999: LLDB qXfer:features:read support.
Apr 13 2015, 4:49 AM
ADodds retitled D8999: LLDB qXfer:features:read support from to LLDB qXfer:features:read support.
Apr 13 2015, 4:47 AM

Dec 18 2014

ADodds added a comment to D6704: Fix compilation faliures for x64 visual studio 2013 build.

Thanks for the insightful feedback and for commiting this change Zachary.

Dec 18 2014, 10:08 AM
ADodds updated the diff for D6704: Fix compilation faliures for x64 visual studio 2013 build.

I have reworked my initial patch with the feedback from Zachary.
I have tested this patch on both x86 and x64 windows builds and successfully build lldb on both.

Dec 18 2014, 9:05 AM
ADodds added a comment to D6704: Fix compilation faliures for x64 visual studio 2013 build.

Selectively including .cpp files in CMake may be harder then it first looks since the LLVM cmake automaticaly throw an error when it finds unincluded .cpp files.
When I tried to bypass RegisterContextWindows_x86.cpp for x64 targets I get the following error:

Dec 18 2014, 3:08 AM

Dec 17 2014

ADodds added a comment to D6702: Work around for Visual Studio 2013 compiler crash.

Thanks very much for committing that Zachary.

Dec 17 2014, 10:07 AM
ADodds planned changes to D6704: Fix compilation faliures for x64 visual studio 2013 build.

Thanks for taking a look at this.
I had an idea that the correct fix may be just what you have mentioned.
I will revise this patch to bypass this file for x64 builds as you advise.

Dec 17 2014, 9:59 AM
ADodds updated the diff for D6702: Work around for Visual Studio 2013 compiler crash.

I have revised the patch after review by Zachary.

Dec 17 2014, 9:51 AM
ADodds added a comment to D6702: Work around for Visual Studio 2013 compiler crash.

I should have added that I cloned from the git mirror at the following
revisions:

Dec 17 2014, 8:33 AM
ADodds added a comment to D6702: Work around for Visual Studio 2013 compiler crash.

Hi Zachary,

Dec 17 2014, 8:30 AM
ADodds retitled D6704: Fix compilation faliures for x64 visual studio 2013 build from to Fix compilation faliures for x64 visual studio 2013 build.
Dec 17 2014, 6:59 AM
ADodds updated subscribers of D6702: Work around for Visual Studio 2013 compiler crash.
Dec 17 2014, 3:52 AM
ADodds retitled D6702: Work around for Visual Studio 2013 compiler crash from to Work around for Visual Studio 2013 compiler crash.
Dec 17 2014, 3:51 AM