Don't remove PIE executables when using svr4 packets

[fjricci]

Summary

Because PIE executables have an e_type of llvm::ELF::ET_DYN,
they are not of type eTypeExecutable, and were being removed
when svr4 packets were used.

[fjricci]

Fix curly-brace style

[fjricci]

Refactor to remove unnecessary object file type checking

[tfiala]

LGTM.

[sas]

Nit: Adding a comment explaining why we special-case the main executable (i.e.: because it is never included in libraries-svr4 packets) might be useful here.

lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

if (new_modules.GetSize() > 0)
 
             bool found = false;
             for (size_t j = 0; j < new_modules.GetSize(); ++j)
             {
                 if (new_modules.GetModuleAtIndex(j).get() == loaded_module.get())
                     found = true;
             }
 
-            if (!found)
+            // The main executable will never be included in libraries-svr4, don't remove it
+            if (!found && loaded_module.get() != target.GetExecutableModulePointer())
             {
-                lldb_private::ObjectFile * obj = loaded_module->GetObjectFile ();
-                if (obj && obj->GetType () != ObjectFile::Type::eTypeExecutable)
-                    removed_modules.Append (loaded_module);
             }
         }
 
         loaded_modules.Remove (removed_modules);
         m_process->GetTarget().ModulesDidUnload (removed_modules, false);
 
         new_modules.ForEach ([&target](const lldb::ModuleSP module_sp) -> bool
         {