This is an archive of the discontinued LLVM Phabricator instance.

[Kaleidoscope] Update docs in Chapter 3 to follow latest code changes
ClosedPublic

Authored by CdTCzech on Jun 3 2016, 4:04 AM.

Details

Reviewers
lhames
Summary
  1. Removed forgotten pointer after modernization. (missed in 246002 by lhames)
  2. Fix static global ordering in docs. (missed in 270381 by lhames)

Diff Detail

Event Timeline

CdTCzech updated this revision to Diff 59501.Jun 3 2016, 4:04 AM
CdTCzech retitled this revision from to [Kaleidoscope] Update docs in Chapter 3 to follow latest code changes.
CdTCzech updated this object.
CdTCzech added a reviewer: lhames.
CdTCzech added a subscriber: llvm-commits.
lhames accepted this revision.Jun 3 2016, 11:00 AM
lhames edited edge metadata.

Looks good to me. Thanks Miroslav!

Do you have commit access? If not, may I commit this on your behalf?

  • Lang.
This revision is now accepted and ready to land.Jun 3 2016, 11:00 AM

Looks good to me. Thanks Miroslav!

Do you have commit access? If not, may I commit this on your behalf?

  • Lang.

No, I'm totally new here. So please commit this.

Thank you Lang,
Miroslav

lhames closed this revision.Jun 6 2016, 10:47 PM

Committed (with a additions to explain the LLVMContext object) in r271985.

Thanks again Miroslav!