[LibFuzzer] Disable building and running LSan tests on Apple platforms because LSan is not currently supported.

[delcypher]

Summary

[LibFuzzer] Disable building and running LSan tests on Apple platforms because LSan is not currently supported.

[kcc]

Why do you need to disable building the tests?
I would expect that "REQUIRES: lsan" is enough. No?

You may find that OutOfMemoryTest also does not *fully* work on OSX after my recent changes -- let's fix it separately.
BTW, it would be lovely if someone can implement lsan support for OSX (i.e. implement StopTheWorld)

lib/Fuzzer/test/CMakeLists.txt

96 ↗

(On Diff #59489)

LeakSanitizer

97 ↗

(On Diff #59489)

LeakSanitizer

[delcypher]

@kcc:

Why do you need to disable building the tests?
I would expect that "REQUIRES: lsan" is enough. No?

My original version (not uploaded to phabricator) of the patch actually didn't disable building the tests. I decided to disable building them because I thought it was odd to build tests that would never be executed. However if you prefer I can change the patch to always build the tests because they do build successfully.

[delcypher]

In D20947#448542, @delcypher wrote:

@kcc:

Why do you need to disable building the tests?
I would expect that "REQUIRES: lsan" is enough. No?

My original version (not uploaded to phabricator) of the patch actually didn't disable building the tests. I decided to disable building them because I thought it was to build tests that would never be executed. However if you prefer I can change the patch to always build the tests because they do build successfully.

Sorry

s/because I thought it was to build/because I thought it was odd to build/

[delcypher]

lib/Fuzzer/test/CMakeLists.txt

97 ↗

(On Diff #59489)

The error message for the "DataflowSanitizer" tests is similarly worded. Do you want that fixed too?

[kcc]

In D20947#448547, @delcypher wrote:

In D20947#448542, @delcypher wrote:

@kcc:

Why do you need to disable building the tests?
I would expect that "REQUIRES: lsan" is enough. No?

My original version (not uploaded to phabricator) of the patch actually didn't disable building the tests. I decided to disable building them because I thought it was to build tests that would never be executed. However if you prefer I can change the patch to always build the tests because they do build successfully.

Sorry

s/because I thought it was to build/because I thought it was odd to build/

Building these tests is very cheap.
Not building them makes the cmake file more complex.
If we can trade a tiny bit of CPU for less complexity we should do it.

lib/Fuzzer/test/CMakeLists.txt

97 ↗

(On Diff #59489)

Yes, would be great.

[delcypher]

lib/Fuzzer/test/CMakeLists.txt

97 ↗

(On Diff #59489)

@kcc: I will this as part of a separate patch because that is unrelated to this change.

[delcypher]

• Build all tests, even the ones we aren't going to run
• Fix Sanitizer marketing s/leak sanitizer/LeakSanitizer/.

[kcc]

LGTM

llvm/trunk/lib/Fuzzer/test/CMakeLists.txt

set(Tests
   SpamyTest
   StrcmpTest
   StrncmpTest
   SwitchTest
   ThreadedTest
   TimeoutTest
   )
 
+if(APPLE)
+  # LeakSanitizer is not supported on OSX right now
+  set(HAS_LSAN 0)
+  message(WARNING "LeakSanitizer is not supported on Apple platforms."
+    " Building and running LibFuzzer LeakSanitizer tests is disabled."
+    )
+else()
+  set(HAS_LSAN 1)
+endif()
+
 foreach(Test ${Tests})
   add_libfuzzer_test(${Test} SOURCES ${Test}.cpp)
 endforeach()
 
 ###############################################################################
 # Unit tests
 ###############################################################################
 

llvm/trunk/lib/Fuzzer/test/fuzzer-leak.test

+REQUIRES: lsan
 RUN: not LLVMFuzzer-LeakTest -runs=100000 -detect_leaks=1 2>&1 | FileCheck %s --check-prefix=LEAK_DURING
 LEAK_DURING: ERROR: LeakSanitizer: detected memory leaks
 LEAK_DURING: Direct leak of 4 byte(s) in 1 object(s) allocated from:
 LEAK_DURING-NOT: DONE
 LEAK_DURING-NOT: Done
 
 RUN: not LLVMFuzzer-LeakTest -runs=0 -detect_leaks=1 %S 2>&1 | FileCheck %s --check-prefix=LEAK_IN_CORPUS
 LEAK_IN_CORPUS: ERROR: LeakSanitizer: detected memory leaks

llvm/trunk/lib/Fuzzer/test/lit.cfg

 config.environment['PATH'] = path
 
 if config.has_dfsan:
   lit_config.note('dfsan feature available')
   config.available_features.add('dfsan')
 else:
   lit_config.note('dfsan feature unavailable')
 
+if config.has_lsan:
+  lit_config.note('lsan feature available')
+  config.available_features.add('lsan')
+else:
+  lit_config.note('lsan feature unavailable')
+

llvm/trunk/lib/Fuzzer/test/lit.site.cfg.in

 config.test_exec_root = "@CMAKE_CURRENT_BINARY_DIR@"
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
 config.has_dfsan = True if @HAS_DFSAN@ == 1 else False
+config.has_lsan = True if @HAS_LSAN@ == 1 else False
 lit_config.load_config(config, "@CMAKE_CURRENT_SOURCE_DIR@/lit.cfg")