This is an archive of the discontinued LLVM Phabricator instance.

Differential D20939

Update for DiagnosticInfoStackSize changes
ClosedPublic

Authored by arsenm on Jun 2 2016, 4:31 PM.

Details

Reviewers
arsenm

Diff Detail

Event Timeline

arsenm updated this revision to Diff 59477.Jun 2 2016, 4:31 PM
arsenm retitled this revision from to Update for DiagnosticInfoStackSize changes.
arsenm updated this object.
arsenm added a parent revision: D20938: Generalize DiagnosticInfoStackSize to support other limits.
arsenm added a subscriber: cfe-commits.
arsenm accepted this revision.Jun 20 2016, 11:20 AM
arsenm added a reviewer: arsenm.

r273178

This revision is now accepted and ready to land.Jun 20 2016, 11:20 AM
arsenm closed this revision.Jun 20 2016, 11:20 AM

Revision Contents

PathSize
lib/
CodeGen/
3 lines
test/
Misc/
10 lines

Diff 59477

lib/CodeGen/CodeGenAction.cpp

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
bool bool
BackendConsumer::StackSizeDiagHandler(const llvm::DiagnosticInfoStackSize &D) { BackendConsumer::StackSizeDiagHandler(const llvm::DiagnosticInfoStackSize &D) {
if (D.getSeverity() != llvm::DS_Warning) if (D.getSeverity() != llvm::DS_Warning)
// For now, the only support we have for StackSize diagnostic is warning. // For now, the only support we have for StackSize diagnostic is warning.
// We do not know how to format other severities. // We do not know how to format other severities.
return false; return false;
if (const Decl *ND = Gen->GetDeclForMangledName(D.getFunction().getName())) { if (const Decl *ND = Gen->GetDeclForMangledName(D.getFunction().getName())) {
// FIXME: Shouldn't need to truncate to uint32_t
Diags.Report(ND->getASTContext().getFullLoc(ND->getLocation()), Diags.Report(ND->getASTContext().getFullLoc(ND->getLocation()),
diag::warn_fe_frame_larger_than) diag::warn_fe_frame_larger_than)
<< D.getStackSize() << Decl::castToDeclContext(ND); << static_cast<uint32_t>(D.getStackSize()) << Decl::castToDeclContext(ND);
return true; return true;
} }
return false; return false;
} }
const FullSourceLoc BackendConsumer::getBestLocationFromDebugLoc( const FullSourceLoc BackendConsumer::getBestLocationFromDebugLoc(
const llvm::DiagnosticInfoWithDebugLocBase &D, bool &BadDebugInfo, StringRef &Filename, const llvm::DiagnosticInfoWithDebugLocBase &D, bool &BadDebugInfo, StringRef &Filename,
▲ Show 20 Lines • Show All 449 Lines • Show Last 20 Lines

test/Misc/backend-resource-limit-diagnostics.cl

  • This file was added.
// REQUIRES: amdgpu-registered-target
// RUN: not %clang_cc1 -emit-codegen-only -triple=amdgcn-- %s 2>&1 | FileCheck %s
// CHECK: error: local memory limit exceeded (480000) in use_huge_lds
kernel void use_huge_lds()
{
volatile local int huge[120000];
huge[0] = 2;
}