There are no tests* and no EABI buildbots.
- There is a single MIPS16 test using a mips*-gnueabi triple but this test doesn't test EABI and the triple doesn't cause EABI to be used.
Paths
| Differential D20906
[mips] EABI CodeGen is completely untested. Remove it. ClosedPublic Authored by dsanders on Jun 2 2016, 5:06 AM.
Details Summary There are no tests* and no EABI buildbots.
Diff Detail
Event Timelinedsanders updated this object. Comment Actions LGTM. I think it's already bitrotted, as a simple test program has crashed during LowerFormalArguments (I reverted your corresponding clang patch locally) to test it quickly. If it can't compile: extern int g(int); extern int k; int f (int a, int b) { return g(a) + g(b) + g(k); } and there's no outstanding bug reports we may as well remove it altogether. We can bring it back if there's interest/requests for it. Comment Actions LGTM. I think it's already bitrotted, as a simple test program has crashed during LowerFormalArguments (I reverted your corresponding clang patch locally) to test it quickly. If it can't compile: extern int g(int); extern int k; int f (int a, int b) { return g(a) + g(b) + g(k); } and there's no outstanding bug reports we may as well remove it altogether. We can bring it back if there's interest/requests for it. This revision is now accepted and ready to land.Jun 2 2016, 8:11 AM dsanders edited edge metadata. Comment ActionsStop the backend determining the ABI from the CPU. The API user should Herald added subscribers: srhines, danalbert, tberghammer. · View Herald TranscriptJun 3 2016, 2:03 AM Closed by commit rL271658: [mips] EABI CodeGen is completely untested and seems to have bitrotted. (authored by dsanders). · Explain WhyJun 3 2016, 3:44 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 59526 llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIInfo.h
llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp
llvm/trunk/lib/Target/Mips/MipsAsmPrinter.cpp
llvm/trunk/lib/Target/Mips/MipsCallingConv.td
llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
llvm/trunk/lib/Target/Mips/MipsSubtarget.h
llvm/trunk/lib/Target/Mips/MipsSubtarget.cpp
|