This is an archive of the discontinued LLVM Phabricator instance.

[include-fixer] added GNU symbols hardcoded header mapping.
ClosedPublic

Authored by ioeric on Jun 2 2016, 2:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ioeric updated this revision to Diff 59353.Jun 2 2016, 2:58 AM
ioeric retitled this revision from to [include-fixer] added GNU symbols hardcoded header mapping..
ioeric updated this object.
ioeric added reviewers: bkramer, klimek.
ioeric added subscribers: hokein, cfe-commits.
bkramer edited edge metadata.Jun 2 2016, 3:49 AM

Can we limit this to actual glibc headers, i.e. the output of dpkg-query -L libc6-dev on Debian/Ubuntu? There are some unrelated headers in there, I don't think we should have them in this list.

ioeric updated this revision to Diff 59411.Jun 2 2016, 9:52 AM
ioeric edited edge metadata.
  • Addressed reviewer's comment.

There are still headers in this list that aren't part of glibc, like curses. I'd rather have those not in the list right now and add stuff as-needed later. I hope that other packages usually found in /usr/include are saner so we don't need to add a header map for them.

ioeric updated this revision to Diff 59499.Jun 3 2016, 1:50 AM
  • Removed non glibc header mapping.
bkramer accepted this revision.Jun 3 2016, 2:22 AM
bkramer edited edge metadata.

lg, thanks!

This revision is now accepted and ready to land.Jun 3 2016, 2:22 AM
This revision was automatically updated to reflect the committed changes.