This is an archive of the discontinued LLVM Phabricator instance.

[include-fixer] use includer of .inc header to be the file path of a symbol from .inc header.
ClosedPublic

Authored by ioeric on Jun 1 2016, 3:45 AM.

Diff Detail

Event Timeline

ioeric updated this revision to Diff 59192.Jun 1 2016, 3:45 AM
ioeric retitled this revision from to [include-fixer] use includer of .inc header to be the file path of a symbol from .inc header..
ioeric updated this object.
ioeric added a subscriber: cfe-commits.
bkramer accepted this revision.Jun 1 2016, 4:31 AM
bkramer edited edge metadata.
bkramer added inline comments.
include-fixer/find-all-symbols/PathConfig.cpp
20

Maybe add a comment that we walk up the include stack for .inc files?

33

Not your fault here, but I'd really prefer

if (Collector)
  FilePath = Collector->getMappedHeader(FilePath);
This revision is now accepted and ready to land.Jun 1 2016, 4:31 AM
ioeric updated this revision to Diff 59200.Jun 1 2016, 4:59 AM
ioeric edited edge metadata.
  • Addressed reviewer's comments.
This revision was automatically updated to reflect the committed changes.