Remove use of is_trivially_constructible.

[ruiu]

Summary

type_traits header in libstdc++ 4.8 does not define is_trivially_contructible
so the code doesn't compile with it.

In this file we are using the trait for assertion to provide a better
error message. Removing it doesn't change the meaning of the code.

[majnemer]

LGTM

include/llvm/DebugInfo/CodeView/StreamArray.h

114–115 ↗

(On Diff #58745)

You could go with std::is_standard_layout<T>::value && std::is_trivial<T>::value to get more or less the same thing.

[ruiu]

include/llvm/DebugInfo/CodeView/StreamArray.h

114–115 ↗

(On Diff #58745)

This seems a bit too tricky to me. It would just fail if you pass non-trivially-constructible class to this one, so I'm okay without this assertion.

[zturner]

Essentially this code was trying to check "is it safe to reinterpret_cast
sizeof(T) bytes to a T*".

Is there a better way to check that?

llvm/trunk/include/llvm/DebugInfo/CodeView/StreamArray.h

 inline VarStreamArrayIterator VarStreamArray::end() const {
   return VarStreamArrayIterator();
 }
 
 template <typename T> class FixedStreamArrayIterator;
 
 template <typename T> class FixedStreamArray {
   friend class FixedStreamArrayIterator<T>;
-  static_assert(std::is_trivially_constructible<T>::value,
-                "FixedStreamArray must be used with trivial types");
 
 public:
   FixedStreamArray() : Stream() {}
   FixedStreamArray(StreamRef Stream) : Stream(Stream) {
     assert(Stream.getLength() % sizeof(T) == 0);
   }
 
   const T &operator[](uint32_t Index) const {