This is an archive of the discontinued LLVM Phabricator instance.

[mips] Kill 'support' for untested EABI.
ClosedPublic

Authored by dsanders on May 26 2016, 7:10 AM.

Details

Summary

There are no clang or llvm* tests for EABI and no EABI buildbots.

*There is a single backend test that specifies EABI but it tests MIPS16.

Depends on D20678

Diff Detail

Repository
rL LLVM

Event Timeline

dsanders updated this revision to Diff 58606.May 26 2016, 7:10 AM
dsanders retitled this revision from to [mips] Kill 'support' for untested EABI..
dsanders updated this object.
dsanders added subscribers: cfe-commits, atanasyan.
atanasyan accepted this revision.May 26 2016, 7:20 AM
atanasyan added a reviewer: atanasyan.

LGTM

Tools.cpp contains the following code. We need to remove eabi here too.

if (CPUName.empty()) {
  // Deduce CPU name from ABI name.
  CPUName = llvm::StringSwitch<const char *>(ABIName)
                .Cases("o32", "eabi", DefMips32CPU)
                .Cases("n32", "n64", DefMips64CPU)
                .Default("");
}
This revision is now accepted and ready to land.May 26 2016, 7:20 AM
dsanders updated this revision to Diff 58772.May 27 2016, 5:39 AM
dsanders edited edge metadata.

Removed the 'eabi' from Tools.cpp this revealed three driver tests for passing
-mabi to the assembler but the ABI itself is still completely untested.

Just to double-check: Do you still agree we should kill this now that the number of tests covering EABI-specific behaviour is non-zero?

I think we should on the basis that we still have no backend tests and no buildbots. The only tests we have check that the driver passes -mabi=eabi to the assembler.

Just to double-check: Do you still agree we should kill this now that the number of tests covering EABI-specific behaviour is non-zero?

I think we should on the basis that we still have no backend tests and no buildbots. The only tests we have check that the driver passes -mabi=eabi to the assembler.

I agree.

dsanders closed this revision.May 27 2016, 7:36 AM
This revision was automatically updated to reflect the committed changes.