This is an archive of the discontinued LLVM Phabricator instance.

Don't pass -fms-compatibility-version flag during build
ClosedPublic

Authored by ismail on May 26 2016, 3:33 AM.

Details

Summary

Since some time clang itself figures out the default for ms-compatibility-version and uses it. Trying to figure it out during build is redundant and also will not work when the environment variable VSINSTALLDIR is not defined (which is not defined if you don't install whole Visual Studio but use Visual C++ Build Tools package).

Tested by bootstrapping clang with clang-cl.

Diff Detail

Repository
rL LLVM

Event Timeline

ismail updated this revision to Diff 58586.May 26 2016, 3:33 AM
ismail retitled this revision from to Don't pass -fms-compatibility-version flag during build.
ismail updated this object.
ismail added reviewers: hans, rnk.
ismail set the repository for this revision to rL LLVM.
ismail added a subscriber: cfe-commits.
hans accepted this revision.May 26 2016, 8:26 AM
hans edited edge metadata.

lgtm if it works :-)

This revision is now accepted and ready to land.May 26 2016, 8:26 AM
This revision was automatically updated to reflect the committed changes.