This is an archive of the discontinued LLVM Phabricator instance.

Differential D20455

[asan] Enable asan Win64 build
ClosedPublic

Authored by wang0109 on May 19 2016, 4:12 PM.

Details

Reviewers
etienneb
rnk
Commits
rG00f3f6e296d4: This patch is activating the build of Asan on Windows 64-bits. It's fixing…
rCRT271049
rL271049
Summary

This patch is activating the build of Asan on Windows 64-bits.
It's fixing compilation errors. The runtime is not yet working.

Missing features:

  • OverrideFunction for x64
  • an equiv function for inline asm (atomic_compare_exchange_strong)
  • shadow memory offset needs to be adjusted
  • RoundUpToInstrBoundary for x64

They will be implemented by subsequent patches.

Diff Detail

Repository
rL LLVM

Event Timeline

wang0109 updated this revision to Diff 57876.May 19 2016, 4:12 PM
wang0109 retitled this revision from to [asan] Enable asan Win64 build.
wang0109 updated this object.
wang0109 added a reviewer: rnk.
Herald added a subscriber: kubamracek. · View Herald TranscriptMay 19 2016, 4:12 PM
wang0109 added a reviewer: etienneb.May 19 2016, 4:13 PM
rnk added inline comments.May 19 2016, 4:25 PM
cmake/config-ix.cmake
438 ↗(On Diff #57876)

I think this is likely to turn this bot red:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/

It builds 'check-all' with compiler-rt on win64, and the tests obviously don't pass yet. I think if you change the code at the end of compiler-rt/test/asan/CMakeLists.txt to set EXCLUDE_FROM_ALL to ON, you can avoid breaking it.

lib/interception/interception_win.cc
154 ↗(On Diff #57876)

Space after //, here and elsewhere

wang0109 added a subscriber: llvm-commits.May 19 2016, 4:28 PM
etienneb updated this object.May 19 2016, 7:41 PM
wang0109 updated this revision to Diff 57932.May 20 2016, 7:47 AM

Update the patch to clean up the spaces and add more comment

wang0109 updated this revision to Diff 57961.May 20 2016, 11:27 AM
  • Update diff for cmake - avoid buildbot fail (need more tests)
rnk added inline comments.May 23 2016, 11:05 AM
test/asan/CMakeLists.txt
96 ↗(On Diff #57961)

You actually want to do this here to affect the main asan test suite, not just the dynamic asan test suite:

if (OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8)
  set(EXCLUDE_FROM_ALL TRUE)
endif()
wang0109 updated this revision to Diff 58331.May 24 2016, 3:21 PM
  • Update cmake files to disable unsupported tests including asan and ubsan with asan
rnk edited edge metadata.May 24 2016, 3:29 PM

Functionally this is fine. Etienne, can you commit this on behalf of Wei after the comment stuff is addressed?

lib/sanitizer_common/sanitizer_atomic_msvc.h
179 ↗(On Diff #58331)

Can you capitalize your comment sentence starts and end them with a period? Sorry I forgot to raise that earlier.

wang0109 updated this revision to Diff 58413.May 25 2016, 7:20 AM
wang0109 edited edge metadata.
  • Update comment format
wang0109 updated this revision to Diff 58414.May 25 2016, 7:22 AM
  • Update comment format again
etienneb edited edge metadata.May 25 2016, 7:32 AM
In D20455#438465, @rnk wrote:

Functionally this is fine. Etienne, can you commit this on behalf of Wei after the comment stuff is addressed?

Ok. I'll do.
I'll try the patch too.

wang0109 updated this revision to Diff 58435.May 25 2016, 9:03 AM
wang0109 edited edge metadata.
  • Update diff for linting style
etienneb added a comment.May 27 2016, 8:36 AM

I tested the patch on my windows machine, and it's working fine.
I'm running unittests on linux.

Could you please fix the remaining nits and I'll land this.

lib/asan/asan_win.cc
73 ↗(On Diff #58435)

no @

156 ↗(On Diff #58435)

There is no "@" here.

lib/interception/interception_win.cc
72 ↗(On Diff #58435)

no @

154 ↗(On Diff #58435)

no @

test/asan/CMakeLists.txt
6 ↗(On Diff #58435)

missing (wwchrome)

126 ↗(On Diff #58435)

ditto

test/ubsan/CMakeLists.txt
35 ↗(On Diff #58435)

ditto

wang0109 updated this revision to Diff 58793.May 27 2016, 8:44 AM
  • Update diff to fix username in TODO
etienneb added a comment.May 27 2016, 8:50 AM

still one missing

lib/sanitizer_common/sanitizer_atomic_msvc.h
179 ↗(On Diff #58793)

no @

wang0109 updated this revision to Diff 58797.May 27 2016, 8:53 AM
  • Fix username in TODO again.
etienneb added a comment.May 27 2016, 9:00 AM

lgtm

I'll land this soon.

etienneb accepted this revision.May 27 2016, 9:00 AM
etienneb edited edge metadata.

lg

This revision is now accepted and ready to land.May 27 2016, 9:00 AM
Closed by commit rL271049 (authored by etienneb). · Explain WhyMay 27 2016, 2:36 PM
This revision was automatically updated to reflect the committed changes.
kubamracek added inline comments.Jun 5 2016, 8:18 AM
compiler-rt/trunk/test/asan/CMakeLists.txt
6–10

I’m not getting this change. I read it like 20 times now, but it still seems it’s disabling ASan tests everywhere, *except* for Win64.

Revision Contents

PathSize
compiler-rt/
trunk/
cmake/
6 lines
lib/
asan/
17 lines
interception/
17 lines
sanitizer_common/
11 lines
test/
asan/
12 lines
ubsan/
6 lines

Diff 58841

compiler-rt/trunk/cmake/config-ix.cmake

Show First 20 Lines • Show All 423 Lines • ▼ Show 20 Lines
if (SANITIZER_COMMON_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND if (SANITIZER_COMMON_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
(OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD" OR (OS_NAME MATCHES "Android|Darwin|Linux|FreeBSD" OR
(OS_NAME MATCHES "Windows" AND MSVC))) (OS_NAME MATCHES "Windows" AND MSVC)))
set(COMPILER_RT_HAS_SANITIZER_COMMON TRUE) set(COMPILER_RT_HAS_SANITIZER_COMMON TRUE)
else() else()
set(COMPILER_RT_HAS_SANITIZER_COMMON FALSE) set(COMPILER_RT_HAS_SANITIZER_COMMON FALSE)
endif() endif()
if (COMPILER_RT_HAS_SANITIZER_COMMON AND if (COMPILER_RT_HAS_SANITIZER_COMMON)
(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 4))
set(COMPILER_RT_HAS_INTERCEPTION TRUE) set(COMPILER_RT_HAS_INTERCEPTION TRUE)
else() else()
set(COMPILER_RT_HAS_INTERCEPTION FALSE) set(COMPILER_RT_HAS_INTERCEPTION FALSE)
endif() endif()
if (COMPILER_RT_HAS_SANITIZER_COMMON AND ASAN_SUPPORTED_ARCH AND if (COMPILER_RT_HAS_SANITIZER_COMMON AND ASAN_SUPPORTED_ARCH)
(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 4))
set(COMPILER_RT_HAS_ASAN TRUE) set(COMPILER_RT_HAS_ASAN TRUE)
else() else()
set(COMPILER_RT_HAS_ASAN FALSE) set(COMPILER_RT_HAS_ASAN FALSE)
endif() endif()
if (OS_NAME MATCHES "Linux|FreeBSD|Windows") if (OS_NAME MATCHES "Linux|FreeBSD|Windows")
set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME TRUE) set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME TRUE)
else() else()
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines

compiler-rt/trunk/lib/asan/asan_win.cc

Show All 40 Lines
// use the /alternatename directive to tell the linker to default a specific // use the /alternatename directive to tell the linker to default a specific
// symbol to a specific value, which works nicely for allocator hooks and // symbol to a specific value, which works nicely for allocator hooks and
// __asan_default_options(). // __asan_default_options().
void __sanitizer_default_malloc_hook(void *ptr, uptr size) { } void __sanitizer_default_malloc_hook(void *ptr, uptr size) { }
void __sanitizer_default_free_hook(void *ptr) { } void __sanitizer_default_free_hook(void *ptr) { }
const char* __asan_default_default_options() { return ""; } const char* __asan_default_default_options() { return ""; }
const char* __asan_default_default_suppressions() { return ""; } const char* __asan_default_default_suppressions() { return ""; }
void __asan_default_on_error() {} void __asan_default_on_error() {}
// 64-bit msvc will not prepend an underscore for symbols.
#ifdef _WIN64
#pragma comment(linker, "/alternatename:__sanitizer_malloc_hook=__sanitizer_default_malloc_hook") // NOLINT
#pragma comment(linker, "/alternatename:__sanitizer_free_hook=__sanitizer_default_free_hook") // NOLINT
#pragma comment(linker, "/alternatename:__asan_default_options=__asan_default_default_options") // NOLINT
#pragma comment(linker, "/alternatename:__asan_default_suppressions=__asan_default_default_suppressions") // NOLINT
#pragma comment(linker, "/alternatename:__asan_on_error=__asan_default_on_error") // NOLINT
#else
#pragma comment(linker, "/alternatename:___sanitizer_malloc_hook=___sanitizer_default_malloc_hook") // NOLINT #pragma comment(linker, "/alternatename:___sanitizer_malloc_hook=___sanitizer_default_malloc_hook") // NOLINT
#pragma comment(linker, "/alternatename:___sanitizer_free_hook=___sanitizer_default_free_hook") // NOLINT #pragma comment(linker, "/alternatename:___sanitizer_free_hook=___sanitizer_default_free_hook") // NOLINT
#pragma comment(linker, "/alternatename:___asan_default_options=___asan_default_default_options") // NOLINT #pragma comment(linker, "/alternatename:___asan_default_options=___asan_default_default_options") // NOLINT
#pragma comment(linker, "/alternatename:___asan_default_suppressions=___asan_default_default_suppressions") // NOLINT #pragma comment(linker, "/alternatename:___asan_default_suppressions=___asan_default_default_suppressions") // NOLINT
#pragma comment(linker, "/alternatename:___asan_on_error=___asan_default_on_error") // NOLINT #pragma comment(linker, "/alternatename:___asan_on_error=___asan_default_on_error") // NOLINT
#endif
// }}} // }}}
} // extern "C" } // extern "C"
// ---------------------- Windows-specific inteceptors ---------------- {{{ // ---------------------- Windows-specific inteceptors ---------------- {{{
INTERCEPTOR_WINAPI(void, RaiseException, void *a, void *b, void *c, void *d) { INTERCEPTOR_WINAPI(void, RaiseException, void *a, void *b, void *c, void *d) {
CHECK(REAL(RaiseException)); CHECK(REAL(RaiseException));
__asan_handle_no_return(); __asan_handle_no_return();
REAL(RaiseException)(a, b, c, d); REAL(RaiseException)(a, b, c, d);
} }
// TODO(wwchrome): Win64 has no _except_handler3/4.
// Need to implement _C_specific_handler instead.
#ifndef _WIN64
INTERCEPTOR(int, _except_handler3, void *a, void *b, void *c, void *d) { INTERCEPTOR(int, _except_handler3, void *a, void *b, void *c, void *d) {
CHECK(REAL(_except_handler3)); CHECK(REAL(_except_handler3));
__asan_handle_no_return(); __asan_handle_no_return();
return REAL(_except_handler3)(a, b, c, d); return REAL(_except_handler3)(a, b, c, d);
} }
#if ASAN_DYNAMIC #if ASAN_DYNAMIC
// This handler is named differently in -MT and -MD CRTs. // This handler is named differently in -MT and -MD CRTs.
#define _except_handler4 _except_handler4_common #define _except_handler4 _except_handler4_common
#endif #endif
INTERCEPTOR(int, _except_handler4, void *a, void *b, void *c, void *d) { INTERCEPTOR(int, _except_handler4, void *a, void *b, void *c, void *d) {
CHECK(REAL(_except_handler4)); CHECK(REAL(_except_handler4));
__asan_handle_no_return(); __asan_handle_no_return();
return REAL(_except_handler4)(a, b, c, d); return REAL(_except_handler4)(a, b, c, d);
} }
#endif
static thread_return_t THREAD_CALLING_CONV asan_thread_start(void *arg) { static thread_return_t THREAD_CALLING_CONV asan_thread_start(void *arg) {
AsanThread *t = (AsanThread*)arg; AsanThread *t = (AsanThread*)arg;
SetCurrentThread(t); SetCurrentThread(t);
return t->ThreadStart(GetTid(), /* signal_thread_is_registered */ nullptr); return t->ThreadStart(GetTid(), /* signal_thread_is_registered */ nullptr);
} }
INTERCEPTOR_WINAPI(DWORD, CreateThread, INTERCEPTOR_WINAPI(DWORD, CreateThread,
▲ Show 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
// }}} // }}}
namespace __asan { namespace __asan {
void InitializePlatformInterceptors() { void InitializePlatformInterceptors() {
ASAN_INTERCEPT_FUNC(CreateThread); ASAN_INTERCEPT_FUNC(CreateThread);
ASAN_INTERCEPT_FUNC(RaiseException); ASAN_INTERCEPT_FUNC(RaiseException);
// TODO(wwchrome): Win64 uses _C_specific_handler instead.
#ifndef _WIN64
ASAN_INTERCEPT_FUNC(_except_handler3); ASAN_INTERCEPT_FUNC(_except_handler3);
ASAN_INTERCEPT_FUNC(_except_handler4); ASAN_INTERCEPT_FUNC(_except_handler4);
#endif
// NtWaitForWorkViaWorkerFactory is always linked dynamically. // NtWaitForWorkViaWorkerFactory is always linked dynamically.
CHECK(::__interception::OverrideFunction( CHECK(::__interception::OverrideFunction(
"NtWaitForWorkViaWorkerFactory", "NtWaitForWorkViaWorkerFactory",
(uptr)WRAP(NtWaitForWorkViaWorkerFactory), (uptr)WRAP(NtWaitForWorkViaWorkerFactory),
(uptr *)&REAL(NtWaitForWorkViaWorkerFactory))); (uptr *)&REAL(NtWaitForWorkViaWorkerFactory)));
} }
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines

compiler-rt/trunk/lib/interception/interception_win.cc

Show All 30 Lines
static void _memcpy(void *dst, void *src, size_t sz) { static void _memcpy(void *dst, void *src, size_t sz) {
char *dst_c = (char*)dst, char *dst_c = (char*)dst,
*src_c = (char*)src; *src_c = (char*)src;
for (size_t i = 0; i < sz; ++i) for (size_t i = 0; i < sz; ++i)
dst_c[i] = src_c[i]; dst_c[i] = src_c[i];
} }
static void WriteJumpInstruction(char *jmp_from, char *to) { static void WriteJumpInstruction(char *jmp_from, char *to) {
// jmp XXYYZZWW = E9 WW ZZ YY XX, where XXYYZZWW is an offset fromt jmp_from // jmp XXYYZZWW = E9 WW ZZ YY XX, where XXYYZZWW is an offset from jmp_from
// to the next instruction to the destination. // to the next instruction to the destination.
ptrdiff_t offset = to - jmp_from - 5; ptrdiff_t offset = to - jmp_from - 5;
*jmp_from = '\xE9'; *jmp_from = '\xE9';
*(ptrdiff_t*)(jmp_from + 1) = offset; *(ptrdiff_t*)(jmp_from + 1) = offset;
} }
static char *GetMemoryForTrampoline(size_t size) { static char *GetMemoryForTrampoline(size_t size) {
// Trampolines are allocated from a common pool. // Trampolines are allocated from a common pool.
Show All 15 Linesstatic char *GetMemoryForTrampoline(size_t size) {
char *ret = pool + pool_used; char *ret = pool + pool_used;
pool_used += size; pool_used += size;
return ret; return ret;
} }
// Returns 0 on error. // Returns 0 on error.
static size_t RoundUpToInstrBoundary(size_t size, char *code) { static size_t RoundUpToInstrBoundary(size_t size, char *code) {
#ifdef _WIN64
// TODO(wwchrome): Implement similar logic for x64 instructions.
// Win64 RoundUpToInstrBoundary is not supported yet.
__debugbreak();
return 0;
#else
size_t cursor = 0; size_t cursor = 0;
while (cursor < size) { while (cursor < size) {
switch (code[cursor]) { switch (code[cursor]) {
case '\x51': // push ecx case '\x51': // push ecx
case '\x52': // push edx case '\x52': // push edx
case '\x53': // push ebx case '\x53': // push ebx
case '\x54': // push esp case '\x54': // push esp
case '\x55': // push ebp case '\x55': // push ebp
▲ Show 20 Lines • Show All 56 Lines • ▼ Show 20 Lines while (cursor < size) {
// in visible and readable error messages. However, merely calling abort() // in visible and readable error messages. However, merely calling abort()
// leads to an infinite recursion in CheckFailed. // leads to an infinite recursion in CheckFailed.
// Do we have a good way to abort with an error message here? // Do we have a good way to abort with an error message here?
__debugbreak(); __debugbreak();
return 0; return 0;
} }
return cursor; return cursor;
#endif
} }
bool OverrideFunction(uptr old_func, uptr new_func, uptr *orig_old_func) { bool OverrideFunction(uptr old_func, uptr new_func, uptr *orig_old_func) {
#ifdef _WIN64 #ifdef _WIN64
#error OverrideFunction is not yet supported on x64 // TODO(wwchrome): Implement using x64 jmp.
#endif // OverrideFunction is not yet supported on x64.
__debugbreak();
return false;
#else
// Function overriding works basically like this: // Function overriding works basically like this:
// We write "jmp <new_func>" (5 bytes) at the beginning of the 'old_func' // We write "jmp <new_func>" (5 bytes) at the beginning of the 'old_func'
// to override it. // to override it.
// We might want to be able to execute the original 'old_func' from the // We might want to be able to execute the original 'old_func' from the
// wrapper, in this case we need to keep the leading 5+ bytes ('head') // wrapper, in this case we need to keep the leading 5+ bytes ('head')
// of the original code somewhere with a "jmp <old_func+head>". // of the original code somewhere with a "jmp <old_func+head>".
// We call these 'head'+5 bytes of instructions a "trampoline". // We call these 'head'+5 bytes of instructions a "trampoline".
char *old_bytes = (char *)old_func; char *old_bytes = (char *)old_func;
Show All 28 Lines#else
WriteJumpInstruction(old_bytes, (char *)new_func); WriteJumpInstruction(old_bytes, (char *)new_func);
_memset(old_bytes + 5, 0xCC /* int 3 */, head - 5); _memset(old_bytes + 5, 0xCC /* int 3 */, head - 5);
// Restore the original permissions. // Restore the original permissions.
if (!VirtualProtect((void *)old_bytes, head, old_prot, &unused_prot)) if (!VirtualProtect((void *)old_bytes, head, old_prot, &unused_prot))
return false; // not clear if this failure bothers us. return false; // not clear if this failure bothers us.
return true; return true;
#endif
} }
static void **InterestingDLLsAvailable() { static void **InterestingDLLsAvailable() {
const char *InterestingDLLs[] = { const char *InterestingDLLs[] = {
"kernel32.dll", "kernel32.dll",
"msvcr110.dll", // VS2012 "msvcr110.dll", // VS2012
"msvcr120.dll", // VS2013 "msvcr120.dll", // VS2013
"vcruntime140.dll", // VS2015 "vcruntime140.dll", // VS2015
▲ Show 20 Lines • Show All 148 Lines • Show Last 20 Lines

compiler-rt/trunk/lib/sanitizer_common/sanitizer_atomic_msvc.h

Show First 20 Lines • Show All 165 Lines • ▼ Show 20 Lines
INLINE u32 atomic_exchange(volatile atomic_uint32_t *a, INLINE u32 atomic_exchange(volatile atomic_uint32_t *a,
u32 v, memory_order mo) { u32 v, memory_order mo) {
(void)mo; (void)mo;
DCHECK(!((uptr)a % sizeof(*a))); DCHECK(!((uptr)a % sizeof(*a)));
return (u32)_InterlockedExchange((volatile long*)&a->val_dont_use, v); return (u32)_InterlockedExchange((volatile long*)&a->val_dont_use, v);
} }
#ifndef _WIN64
INLINE bool atomic_compare_exchange_strong(volatile atomic_uint8_t *a, INLINE bool atomic_compare_exchange_strong(volatile atomic_uint8_t *a,
u8 *cmp, u8 *cmp,
u8 xchgv, u8 xchgv,
memory_order mo) { memory_order mo) {
#ifdef _WIN64
// TODO(wwchrome): Implement same functionality without inline asm.
// Inline asm not supported in Win64.
__debugbreak();
return false;
#else
(void)mo; (void)mo;
DCHECK(!((uptr)a % sizeof(*a))); DCHECK(!((uptr)a % sizeof(*a)));
u8 cmpv = *cmp; u8 cmpv = *cmp;
u8 prev; u8 prev;
__asm { __asm {
mov al, cmpv mov al, cmpv
mov ecx, a mov ecx, a
mov dl, xchgv mov dl, xchgv
lock cmpxchg [ecx], dl lock cmpxchg [ecx], dl
mov prev, al mov prev, al
} }
if (prev == cmpv) if (prev == cmpv)
return true; return true;
*cmp = prev; *cmp = prev;
return false; return false;
}
#endif #endif
}
INLINE bool atomic_compare_exchange_strong(volatile atomic_uintptr_t *a, INLINE bool atomic_compare_exchange_strong(volatile atomic_uintptr_t *a,
uptr *cmp, uptr *cmp,
uptr xchg, uptr xchg,
memory_order mo) { memory_order mo) {
uptr cmpv = *cmp; uptr cmpv = *cmp;
uptr prev = (uptr)_InterlockedCompareExchangePointer( uptr prev = (uptr)_InterlockedCompareExchangePointer(
(void*volatile*)&a->val_dont_use, (void*)xchg, (void*)cmpv); (void*volatile*)&a->val_dont_use, (void*)xchg, (void*)cmpv);
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines

compiler-rt/trunk/test/asan/CMakeLists.txt

set(ASAN_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(ASAN_LIT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
set(ASAN_TESTSUITES) set(ASAN_TESTSUITES)
set(ASAN_DYNAMIC_TESTSUITES) set(ASAN_DYNAMIC_TESTSUITES)
# TODO(wwchrome): Re-enable Win64 asan tests when ready.
# Disable tests for asan Win64 temporarily.
if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
set(EXCLUDE_FROM_ALL TRUE)
endif()
kubamracekUnsubmitted
Not Done
ReplyInline Actions

I’m not getting this change. I read it like 20 times now, but it still seems it’s disabling ASan tests everywhere, *except* for Win64.

kubamracek: I’m not getting this change. I read it like 20 times now, but it still seems it’s disabling…
macro(get_bits_for_arch arch bits) macro(get_bits_for_arch arch bits)
if (${arch} MATCHES "i386|i686|arm|mips|mipsel") if (${arch} MATCHES "i386|i686|arm|mips|mipsel")
set(${bits} 32) set(${bits} 32)
elseif (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|mips64|mips64el|s390x") elseif (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|mips64|mips64el|s390x")
set(${bits} 64) set(${bits} 64)
else() else()
message(FATAL_ERROR "Unknown target architecture: ${arch}") message(FATAL_ERROR "Unknown target architecture: ${arch}")
endif() endif()
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
add_lit_testsuite(check-asan "Running the AddressSanitizer tests" add_lit_testsuite(check-asan "Running the AddressSanitizer tests"
${ASAN_TESTSUITES} ${ASAN_TESTSUITES}
DEPENDS ${ASAN_TEST_DEPS}) DEPENDS ${ASAN_TEST_DEPS})
set_target_properties(check-asan PROPERTIES FOLDER "ASan tests") set_target_properties(check-asan PROPERTIES FOLDER "ASan tests")
if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME) if(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME)
# Add check-dynamic-asan target. It is a part of check-all only on Windows, # Add check-dynamic-asan target. It is a part of check-all only on Windows,
# where we want to always test both dynamic and static runtime. # where we want to always test both dynamic and static runtime.
if(NOT OS_NAME MATCHES "Windows") if(NOT OS_NAME MATCHES "Windows")
set(EXCLUDE_FROM_ALL TRUE) set(EXCLUDE_FROM_ALL TRUE)
endif() endif()
add_lit_testsuite(check-asan-dynamic add_lit_testsuite(check-asan-dynamic
"Running the AddressSanitizer tests with dynamic runtime" "Running the AddressSanitizer tests with dynamic runtime"
${ASAN_DYNAMIC_TESTSUITES} ${ASAN_DYNAMIC_TESTSUITES}
DEPENDS ${ASAN_DYNAMIC_TEST_DEPS}) DEPENDS ${ASAN_DYNAMIC_TEST_DEPS})
set_target_properties(check-asan-dynamic set_target_properties(check-asan-dynamic
PROPERTIES FOLDER "ASan dynamic tests") PROPERTIES FOLDER "ASan dynamic tests")
if(NOT OS_NAME MATCHES "Windows") if(NOT OS_NAME MATCHES "Windows")
set(EXCLUDE_FROM_ALL FALSE) set(EXCLUDE_FROM_ALL FALSE)
endif() endif()
endif() endif()
# TODO(wwchrome): Re-enable the tests for asan Win64 when ready.
if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 8)
set(EXCLUDE_FROM_ALL FALSE)
endif()

compiler-rt/trunk/test/ubsan/CMakeLists.txt

Show All 26 Lines if(${arch} MATCHES "arm|aarch64")
set(UBSAN_TEST_TARGET_CFLAGS ${COMPILER_RT_TEST_COMPILER_CFLAGS}) set(UBSAN_TEST_TARGET_CFLAGS ${COMPILER_RT_TEST_COMPILER_CFLAGS})
else() else()
get_target_flags_for_arch(${arch} UBSAN_TEST_TARGET_CFLAGS) get_target_flags_for_arch(${arch} UBSAN_TEST_TARGET_CFLAGS)
string(REPLACE ";" " " UBSAN_TEST_TARGET_CFLAGS "${UBSAN_TEST_TARGET_CFLAGS}") string(REPLACE ";" " " UBSAN_TEST_TARGET_CFLAGS "${UBSAN_TEST_TARGET_CFLAGS}")
endif() endif()
add_ubsan_testsuite("Standalone" ubsan ${arch}) add_ubsan_testsuite("Standalone" ubsan ${arch})
if(COMPILER_RT_HAS_ASAN AND ";${ASAN_SUPPORTED_ARCH};" MATCHES ";${arch};") if(COMPILER_RT_HAS_ASAN AND ";${ASAN_SUPPORTED_ARCH};" MATCHES ";${arch};")
# TODO(wwchrome): Re-enable ubsan for asan win 64-bit when ready.
# Disable ubsan with AddressSanitizer tests for Windows 64-bit.
if(NOT OS_NAME MATCHES "Windows" OR CMAKE_SIZEOF_VOID_P EQUAL 4)
add_ubsan_testsuite("AddressSanitizer" asan ${arch}) add_ubsan_testsuite("AddressSanitizer" asan ${arch})
endif() endif()
endif()
if(COMPILER_RT_HAS_MSAN AND ";${MSAN_SUPPORTED_ARCH};" MATCHES ";${arch};") if(COMPILER_RT_HAS_MSAN AND ";${MSAN_SUPPORTED_ARCH};" MATCHES ";${arch};")
add_ubsan_testsuite("MemorySanitizer" msan ${arch}) add_ubsan_testsuite("MemorySanitizer" msan ${arch})
endif() endif()
if(COMPILER_RT_HAS_TSAN AND ";${TSAN_SUPPORTED_ARCH};" MATCHES ";${arch};") if(COMPILER_RT_HAS_TSAN AND ";${TSAN_SUPPORTED_ARCH};" MATCHES ";${arch};")
add_ubsan_testsuite("ThreadSanitizer" tsan ${arch}) add_ubsan_testsuite("ThreadSanitizer" tsan ${arch})
endif() endif()
endforeach() endforeach()
add_lit_testsuite(check-ubsan "Running UndefinedBehaviorSanitizer tests" add_lit_testsuite(check-ubsan "Running UndefinedBehaviorSanitizer tests"
${UBSAN_TESTSUITES} ${UBSAN_TESTSUITES}
DEPENDS ${UBSAN_TEST_DEPS}) DEPENDS ${UBSAN_TEST_DEPS})
set_target_properties(check-ubsan PROPERTIES FOLDER "UBSan tests") set_target_properties(check-ubsan PROPERTIES FOLDER "UBSan tests")