This is an archive of the discontinued LLVM Phabricator instance.

[include-fixer] Make search handle fully qualified names correctly.
ClosedPublic

Authored by bkramer on May 19 2016, 5:23 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

bkramer updated this revision to Diff 57766.May 19 2016, 5:23 AM
bkramer retitled this revision from to [include-fixer] Make search handle fully qualified names correctly..
bkramer updated this object.
bkramer added reviewers: hokein, ioeric.
bkramer added a subscriber: cfe-commits.
hokein accepted this revision.May 19 2016, 5:46 AM
hokein edited edge metadata.

LGTM with one nit.

include-fixer/SymbolIndexManager.cpp
73 ↗(On Diff #57766)

Might be IsMatched &= (SymbolContext == Symbol.getContexts().end()); for reading clearly?

This revision is now accepted and ready to land.May 19 2016, 5:46 AM
This revision was automatically updated to reflect the committed changes.