This is an archive of the discontinued LLVM Phabricator instance.

[Clang][AVX512][intrinsics] Fix vperm intrinsics.
AbandonedPublic

Authored by igorb on May 17 2016, 4:22 AM.

Details

Summary

[Clang][AVX512][intrinsics] Fix vperm{w|d|q|ps|pd} intrinsics. Index is first argument to buildin function.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 57457.May 17 2016, 4:22 AM
igorb retitled this revision from to [Clang][AVX512][intrinsics] Fix vperm intrinsics..
igorb updated this object.
igorb added reviewers: m_zuckerman, AsafBadouh, delena.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: cfe-commits.
m_zuckerman accepted this revision.May 18 2016, 5:34 AM
m_zuckerman edited edge metadata.

lgtm

This revision is now accepted and ready to land.May 18 2016, 5:34 AM
craig.topper requested changes to this revision.May 18 2016, 8:19 AM
craig.topper added a reviewer: craig.topper.
craig.topper added a subscriber: craig.topper.

Don't the type casts need to be changed too? For example permutexvar_pd has the index as __v8df.

This revision now requires changes to proceed.May 18 2016, 8:19 AM

Thanks, you are right !

igorb updated this revision to Diff 58055.May 22 2016, 7:48 AM
igorb edited edge metadata.

Update path according to comments.
Thanks for review, Craig !

Looking at this again. This doesn't match the gcc implementation of the builtins. Unless their header file is also wrong. Can you clarify?

igorb added a comment.May 23 2016, 4:13 AM

Looking at this again. This doesn't match the gcc implementation of the builtins. Unless their header file is also wrong. Can you clarify?

Thanks,
You are correct. I implemented all changes in code-gen ( http://reviews.llvm.org/D20515 ).
If there's no objection, I abandon this review.

igorb abandoned this revision.May 24 2016, 4:13 AM