This is an archive of the discontinued LLVM Phabricator instance.

Differential D20234

Do not assume InstAlias operands appear after a blank
ClosedPublic

Authored by rogfer01 on May 13 2016, 5:11 AM.

Details

Reviewers
ahatanak
stoklund
olista01
Commits
rG3c2f78576912: AsmWriterEmitter.cpp assumes that all operands of a printed alias will appear…
rL271666: AsmWriterEmitter.cpp assumes that all operands of a printed alias
Summary

AsmWriterEmitter.cpp assumes that all operands of a printed alias
will appear after a blank. This assumption does not hold in the ARM
target.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 updated this revision to Diff 57161.May 13 2016, 5:11 AM
rogfer01 retitled this revision from to Do not assume InstAlias operands appear after a blank.
rogfer01 updated this object.
rogfer01 added a reviewer: stoklund.
rogfer01 added a subscriber: llvm-commits.
Herald added a subscriber: aemerson. · View Herald TranscriptMay 13 2016, 5:11 AM
rogfer01 added a child revision: D20237: Use printAliasInstr in ARM target.May 13 2016, 7:05 AM
rogfer01 added a comment.May 20 2016, 5:28 AM

Ping?

Regards

rogfer01 added a comment.May 25 2016, 3:17 AM

Ping?

rogfer01 added a reviewer: ahatanak.May 27 2016, 5:20 AM
rogfer01 added a comment.May 31 2016, 3:47 AM

Ping?

Kind regards,

rogfer01 added a comment.Jun 2 2016, 12:31 AM

Ping?

Thank you very much,

rogfer01 added a reviewer: olista01.Jun 3 2016, 1:39 AM
rogfer01 added a comment.Jun 3 2016, 1:53 AM

Ping?

Thank you.

olista01 accepted this revision.Jun 3 2016, 5:29 AM
olista01 edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 3 2016, 5:29 AM
Closed by commit rL271666: AsmWriterEmitter.cpp assumes that all operands of a printed alias (authored by SjoerdMeijer). · Explain WhyJun 3 2016, 6:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
utils/
TableGen/
7 lines

Diff 59542

llvm/trunk/utils/TableGen/AsmWriterEmitter.cpp

Show First 20 Lines • Show All 1,001 Lines • ▼ Show 20 Linesvoid AsmWriterEmitter::EmitPrintAliasInstruction(raw_ostream &O) {
O.indent(2) << "switch (MI->getOpcode()) {\n"; O.indent(2) << "switch (MI->getOpcode()) {\n";
O.indent(2) << "default: return false;\n"; O.indent(2) << "default: return false;\n";
O << CasesO.str(); O << CasesO.str();
O.indent(2) << "}\n\n"; O.indent(2) << "}\n\n";
// Code that prints the alias, replacing the operands with the ones from the // Code that prints the alias, replacing the operands with the ones from the
// MCInst. // MCInst.
O << " unsigned I = 0;\n"; O << " unsigned I = 0;\n";
O << " while (AsmString[I] != ' ' && AsmString[I] != '\t' &&\n"; O << " while (AsmString[I] != ' ' && AsmString[I] != '\\t' &&\n";
O << " AsmString[I] != '\\0')\n"; O << " AsmString[I] != '$' && AsmString[I] != '\\0')\n";
O << " ++I;\n"; O << " ++I;\n";
O << " OS << '\\t' << StringRef(AsmString, I);\n"; O << " OS << '\\t' << StringRef(AsmString, I);\n";
O << " if (AsmString[I] != '\\0') {\n"; O << " if (AsmString[I] != '\\0') {\n";
O << " if (AsmString[I] == ' ' || AsmString[I] == '\\t')";
O << " OS << '\\t';\n"; O << " OS << '\\t';\n";
O << " do {\n"; O << " do {\n";
O << " if (AsmString[I] == '$') {\n"; O << " if (AsmString[I] == '$') {\n";
O << " ++I;\n"; O << " ++I;\n";
O << " if (AsmString[I] == (char)0xff) {\n"; O << " if (AsmString[I] == (char)0xff) {\n";
O << " ++I;\n"; O << " ++I;\n";
O << " int OpIdx = AsmString[I++] - 1;\n"; O << " int OpIdx = AsmString[I++] - 1;\n";
O << " int PrintMethodIdx = AsmString[I++] - 1;\n"; O << " int PrintMethodIdx = AsmString[I++] - 1;\n";
O << " printCustomAliasOperand(MI, OpIdx, PrintMethodIdx, "; O << " printCustomAliasOperand(MI, OpIdx, PrintMethodIdx, ";
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines