This is an archive of the discontinued LLVM Phabricator instance.

Differential D20224

Unbreak build on NetBSD-7.0
AbandonedPublic

Authored by krytarowski on May 12 2016, 6:07 PM.

Details

Reviewers
emaste
joerg
clayborg
Summary

NetBSD 7.0 ships with too old libstdc++ and it lacks <codecvt>.

It's no longer true in the current version -- it has been tested with 7.99.28.

This arbitrary value is an temporary version just to retain building on 7.0 and head for fully functional NetBSD-8.0.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski updated this revision to Diff 57122.May 12 2016, 6:07 PM
krytarowski retitled this revision from to Unbreak build on NetBSD-7.0.
krytarowski updated this object.
krytarowski added reviewers: joerg, emaste, clayborg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.
krytarowski abandoned this revision.May 13 2016, 7:06 PM

I'm giving up on LLDB in NetBSD-7.0, I'm working on upcoming NetBSD-8.0.

Revision Contents

PathSize
include/
lldb/
Host/
11 lines

Diff 57122

include/lldb/Host/Editline.h

Show All 17 Lines
// b) The prompt printing logic for dealing with ANSI formatting characters is broken, which is why we're // b) The prompt printing logic for dealing with ANSI formatting characters is broken, which is why we're
// working around it here. // working around it here.
// c) When resizing the terminal window, if the cursor moves between rows libedit will get confused. // c) When resizing the terminal window, if the cursor moves between rows libedit will get confused.
// d) The incremental search uses escape to cancel input, so it's confused by ANSI sequences starting with escape. // d) The incremental search uses escape to cancel input, so it's confused by ANSI sequences starting with escape.
// e) Emoji support is fairly terrible, presumably it doesn't understand composed characters? // e) Emoji support is fairly terrible, presumably it doesn't understand composed characters?
#ifndef liblldb_Editline_h_ #ifndef liblldb_Editline_h_
#define liblldb_Editline_h_ #define liblldb_Editline_h_
#if defined(__NetBSD__)
#include <sys/param.h>
#if __NetBSD_Prereq__(7,99,28)
#define NETBSD_USE_WCHAR
#endif
#endif
#if defined(__cplusplus) #if defined(__cplusplus)
#include <sstream> #include <sstream>
#include <vector> #include <vector>
#include <locale> #include <locale>
// components needed to handle wide characters ( <codecvt>, codecvt_utf8, libedit built with '--enable-widec' ) // components needed to handle wide characters ( <codecvt>, codecvt_utf8, libedit built with '--enable-widec' )
// are available on some platforms. The wchar_t versions of libedit functions will only be // are available on some platforms. The wchar_t versions of libedit functions will only be
// used in cases where this is true. This is a compile time dependecy, for now selected per target Platform // used in cases where this is true. This is a compile time dependecy, for now selected per target Platform
#if defined (__APPLE__) || defined(__NetBSD__) #if defined (__APPLE__) || defined(NETBSD_USE_WCHAR)
#define LLDB_EDITLINE_USE_WCHAR 1 #define LLDB_EDITLINE_USE_WCHAR 1
#include <codecvt> #include <codecvt>
#else #else
#define LLDB_EDITLINE_USE_WCHAR 0 #define LLDB_EDITLINE_USE_WCHAR 0
#endif #endif
#include "lldb/lldb-private.h" #include "lldb/lldb-private.h"
#include "lldb/Host/ConnectionFileDescriptor.h" #include "lldb/Host/ConnectionFileDescriptor.h"
▲ Show 20 Lines • Show All 324 Lines • Show Last 20 Lines