[MIB] Create a helper function getRegState to extract all register flags

[kparzysz]

Summary

When creating a new instruction that is based on an existing one, it may be useful to have a simple way of extracting the union of all flags from a register operand.

[qcolombet]

Hi Krzysztof,

LGTM with a doxygen comment on the added function.

Cheers,
-Quentin

include/llvm/CodeGen/MachineInstrBuilder.h

389

Add a doxygen comment on that function.

[kparzysz]

Committed in r269414 with the requested change. Forgot to add the "Differential Revision" to the commit message so this review did not get closed automatically.

include/llvm/CodeGen/MachineInstrBuilder.h

 }
 inline unsigned getInternalReadRegState(bool B) {
   return B ? RegState::InternalRead : 0;
 }
 inline unsigned getDebugRegState(bool B) {
   return B ? RegState::Debug : 0;
 }
 
+inline unsigned getRegState(const MachineOperand &RegOp) {
+  assert(RegOp.isReg() && "Not a register operand");
+  return getDefRegState(RegOp.isDef())                    |
+         getImplRegState(RegOp.isImplicit())              |
+         getKillRegState(RegOp.isKill())                  |
+         getDeadRegState(RegOp.isDead())                  |
+         getUndefRegState(RegOp.isUndef())                |
+         getInternalReadRegState(RegOp.isInternalRead())  |
+         getDebugRegState(RegOp.isDebug());
+}
 
 /// Helper class for constructing bundles of MachineInstrs.
 ///
 /// MIBundleBuilder can create a bundle from scratch by inserting new
 /// MachineInstrs one at a time, or it can create a bundle from a sequence of
 /// existing MachineInstrs in a basic block.
 class MIBundleBuilder {
   MachineBasicBlock &MBB;

lib/Target/Hexagon/HexagonSplitDouble.cpp

namespace {
   const TargetRegisterClass *const HexagonSplitDoubleRegs::DoubleRC
       = &Hexagon::DoubleRegsRegClass;
 }
 
 INITIALIZE_PASS(HexagonSplitDoubleRegs, "hexagon-split-double",
   "Hexagon Split Double Registers", false, false)
 
 
-static inline uint32_t getRegState(const MachineOperand &R) {
-  assert(R.isReg());
-  return getDefRegState(R.isDef()) |
-         getImplRegState(R.isImplicit()) |
-         getKillRegState(R.isKill()) |
-         getDeadRegState(R.isDead()) |
-         getUndefRegState(R.isUndef()) |
-         getInternalReadRegState(R.isInternalRead()) |
-         (R.isDebug() ? RegState::Debug : 0);
-}
-
-
 void HexagonSplitDoubleRegs::dump_partition(raw_ostream &os,
       const USet &Part, const TargetRegisterInfo &TRI) {
   dbgs() << '{';
   for (auto I : Part)
     dbgs() << ' ' << PrintReg(I, &TRI);
   dbgs() << " }";
 }