Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (404 w, 3 d)

Recent Activity

Fri, Jan 14

kparzysz committed rGbde1032588f7: [Hexagon] Fix optimize address mode pass only handle BaseImmOffset mode (authored by pranavb).
[Hexagon] Fix optimize address mode pass only handle BaseImmOffset mode
Fri, Jan 14, 3:46 PM
kparzysz closed D117133: Fix Hexagon optimize addressing mode pass so that it handles only BaseImmOffset addressing mode..
Fri, Jan 14, 3:45 PM · Restricted Project

Fri, Jan 7

kparzysz committed rGec2945d031b6: [Hexagon] Reconize M2_mnaci in HexagonBitTracker (authored by sgundapa).
[Hexagon] Reconize M2_mnaci in HexagonBitTracker
Fri, Jan 7, 2:49 PM
kparzysz committed rG07ecb987987b: [Hexagon] Use map from HexagonDepArch instead of local one, NFC (authored by kparzysz).
[Hexagon] Use map from HexagonDepArch instead of local one, NFC
Fri, Jan 7, 1:03 PM
kparzysz committed rGd9ee9a1419ed: [Hexagon] Extract condition into function, NFC (authored by kparzysz).
[Hexagon] Extract condition into function, NFC
Fri, Jan 7, 12:35 PM
kparzysz committed rGdfbe74be63c2: [Hexagon] Fix release build break after 547658567353d (authored by kparzysz).
[Hexagon] Fix release build break after 547658567353d
Fri, Jan 7, 12:22 PM
kparzysz committed rG028444c2b329: [Hexagon] Duplex error: wrong branch hint (authored by Michael Lambert <mlambert@quicinc.com>).
[Hexagon] Duplex error: wrong branch hint
Fri, Jan 7, 12:04 PM
kparzysz committed rG4096ef3ed70d: [Hexagon] Consider direction hint forming dealloc_return duplex (authored by colinl).
[Hexagon] Consider direction hint forming dealloc_return duplex
Fri, Jan 7, 12:04 PM
kparzysz committed rG547658567353: [Hexagon] Improve check for subinstruction registers (authored by colinl).
[Hexagon] Improve check for subinstruction registers
Fri, Jan 7, 11:39 AM
kparzysz committed rG137642f433c6: [Hexagon] Reject accumulating on vd.tmp (authored by hexhexd).
[Hexagon] Reject accumulating on vd.tmp
Fri, Jan 7, 11:18 AM
kparzysz committed rG1f71e46f2a4f: [Hexagon] Apply tiny core packet size slots limit (authored by androm3da).
[Hexagon] Apply tiny core packet size slots limit
Fri, Jan 7, 10:33 AM
kparzysz committed rGa2473601736d: [Hexagon] Simplify AX instruction detection (authored by colinl).
[Hexagon] Simplify AX instruction detection
Fri, Jan 7, 10:33 AM
kparzysz committed rG9af53d2f0cff: [Hexagon] s/Fatal/ReportErrors/ (authored by bcain).
[Hexagon] s/Fatal/ReportErrors/
Fri, Jan 7, 8:28 AM
kparzysz committed rG5001c7cc9dad: [Hexagon] MC testcases for verifying packetization rules (authored by colinl).
[Hexagon] MC testcases for verifying packetization rules
Fri, Jan 7, 8:28 AM
kparzysz committed rGa58a062fbae0: [Hexagon] Show slot resources for errors (authored by androm3da).
[Hexagon] Show slot resources for errors
Fri, Jan 7, 8:28 AM
kparzysz committed rG88397739a300: [Hexagon] Misc shuffling fixes (authored by kparzysz).
[Hexagon] Misc shuffling fixes
Fri, Jan 7, 8:28 AM

Thu, Jan 6

kparzysz committed rGe37b6a67f8a7: [Hexagon] Some compound opportunities missed in presence of branches (authored by colinl).
[Hexagon] Some compound opportunities missed in presence of branches
Thu, Jan 6, 2:21 PM
kparzysz committed rGddf1fb1f133a: [Hexagon] Save results from partial compound (authored by androm3da).
[Hexagon] Save results from partial compound
Thu, Jan 6, 2:09 PM
kparzysz committed rGafdc6a0b8eee: [Hexagon] Some compound opportunities missed in presence of branches (authored by colinl).
[Hexagon] Some compound opportunities missed in presence of branches
Thu, Jan 6, 9:30 AM
kparzysz committed rGb17f036a99eb: [Hexagon] Consider HVX reg aliases for .cur warning (authored by androm3da).
[Hexagon] Consider HVX reg aliases for .cur warning
Thu, Jan 6, 9:06 AM

Wed, Jan 5

kparzysz committed rG2819e5de42e0: [Hexagon] Handle instruction selection for select(I1,Q,Q) (authored by iajbar).
[Hexagon] Handle instruction selection for select(I1,Q,Q)
Wed, Jan 5, 2:57 PM
kparzysz committed rG3892baaa711a: [Hexagon] Replace isImmValidForOpcode() with isExtendable flag (authored by iajbar).
[Hexagon] Replace isImmValidForOpcode() with isExtendable flag
Wed, Jan 5, 1:25 PM
kparzysz committed rGf6309db719a4: [Hexagon] Handle L2_loadb[sz]w[24]_io in HII::isValidOffset (authored by kparzysz).
[Hexagon] Handle L2_loadb[sz]w[24]_io in HII::isValidOffset
Wed, Jan 5, 1:25 PM
kparzysz committed rG9d0f5c1f8ef1: [Hexagon] Add missing memop instructions to HexagonInstrInfo (authored by sgundapa).
[Hexagon] Add missing memop instructions to HexagonInstrInfo
Wed, Jan 5, 1:25 PM
kparzysz committed rG69deb3c8297b: [Hexagon] Update instruction info for missing .cur post-increment cases (authored by sgundapa).
[Hexagon] Update instruction info for missing .cur post-increment cases
Wed, Jan 5, 1:25 PM
kparzysz committed rG41085357df2b: [Hexagon] Extend OptAddrMode pass to vgather (authored by Shubham Pawar <shubhamp@quicinc.com>).
[Hexagon] Extend OptAddrMode pass to vgather
Wed, Jan 5, 8:44 AM
kparzysz committed rG9aa017342c8f: [Hexagon] Add setting hvx-qfloat in HexagonMCSubtargetInfo (authored by Joshua Herrera <joshherr@quicinc.com>).
[Hexagon] Add setting hvx-qfloat in HexagonMCSubtargetInfo
Wed, Jan 5, 7:55 AM

Tue, Jan 4

kparzysz committed rG822448635edc: [Hexagon] Fix MachineSink not to hoist FP instructions that update USR. (authored by sgundapa).
[Hexagon] Fix MachineSink not to hoist FP instructions that update USR.
Tue, Jan 4, 3:56 PM
kparzysz committed rG52f347010a8c: [Hexagon] Make A2_tfrsi not cheap for operands exceeding 16 bits (authored by SANTANU DAS <santanudas@codeaurora.org>).
[Hexagon] Make A2_tfrsi not cheap for operands exceeding 16 bits
Tue, Jan 4, 3:48 PM
kparzysz committed rG60944d132fe3: [Hexagon] Convert codegen testcase from .ll to .mir (authored by kparzysz).
[Hexagon] Convert codegen testcase from .ll to .mir
Tue, Jan 4, 3:42 PM
kparzysz committed rG090f8ec8a8dc: [Hexagon] Fix some issues with packetizing slot0-only instructions (authored by bcahoon).
[Hexagon] Fix some issues with packetizing slot0-only instructions
Tue, Jan 4, 2:40 PM
kparzysz committed rG2b1c6df5a60a: [Hexagon] Performance regression with b2b (authored by hjagasia).
[Hexagon] Performance regression with b2b
Tue, Jan 4, 2:14 PM
kparzysz committed rGcff1a2ed5159: [Hexagon] HVX .new store uses different resources (authored by SANTANU DAS <santanudas@codeaurora.org>).
[Hexagon] HVX .new store uses different resources
Tue, Jan 4, 1:43 PM
kparzysz committed rGd6a68d08f384: [Hexagon] Refactor updateLatency() function (authored by iajbar).
[Hexagon] Refactor updateLatency() function
Tue, Jan 4, 1:17 PM
kparzysz committed rG9b63fff3db88: [Hexagon] Update latencies on REG_SEQUENCE/COPY based on successors. (authored by sgundapa).
[Hexagon] Update latencies on REG_SEQUENCE/COPY based on successors.
Tue, Jan 4, 12:31 PM
kparzysz committed rGdb5b7915959a: [Hexagon] Fix an instruction move in HexagonVectorCombine (authored by bcahoon).
[Hexagon] Fix an instruction move in HexagonVectorCombine
Tue, Jan 4, 11:47 AM
kparzysz committed rGe88eb6443fe0: [Hexagon] Fix buildVector32 for v4i8 constants (authored by Tasmia Rahman <trahman@quicinc.com>).
[Hexagon] Fix buildVector32 for v4i8 constants
Tue, Jan 4, 11:24 AM
kparzysz committed rG78f5014fea9d: [Hexagon] Conversions to/from FP types, HVX and scalar (authored by kparzysz).
[Hexagon] Conversions to/from FP types, HVX and scalar
Tue, Jan 4, 11:04 AM

Thu, Dec 30

kparzysz committed rGdb83e3e5071a: [Hexagon] Generate HVX/FP arithmetic instructions (authored by kparzysz).
[Hexagon] Generate HVX/FP arithmetic instructions
Thu, Dec 30, 12:48 PM
kparzysz committed rG9e6afbedb016: [Hexagon] Generate HVX/FP compare instructions (authored by kparzysz).
[Hexagon] Generate HVX/FP compare instructions
Thu, Dec 30, 12:17 PM
kparzysz committed rGe107374e40a2: [Hexagon] Explicitly use integer types when rescaling a mask (authored by kparzysz).
[Hexagon] Explicitly use integer types when rescaling a mask
Thu, Dec 30, 10:18 AM
kparzysz committed rGeb574259b696: [Hexagon] Handle HVX/FP {masked,wide} loads/stores (authored by kparzysz).
[Hexagon] Handle HVX/FP {masked,wide} loads/stores
Thu, Dec 30, 10:18 AM
kparzysz committed rGcd997689f26d: [Hexagon] Fix isTypeForHVX to recognize floating point types (authored by kparzysz).
[Hexagon] Fix isTypeForHVX to recognize floating point types
Thu, Dec 30, 10:01 AM
kparzysz committed rG23423638cc69: [Hexagon] Handle HVX/FP shuffles, insertion and extraction (authored by kparzysz).
[Hexagon] Handle HVX/FP shuffles, insertion and extraction
Thu, Dec 30, 8:50 AM
kparzysz added a reverting change for rGba07f300c6d6: [Hexagon] Don't build two halves of HVX vector in parallel: rG95c7dd8810b0: Revert "[Hexagon] Don't build two halves of HVX vector in parallel".
Thu, Dec 30, 8:14 AM
kparzysz committed rG95c7dd8810b0: Revert "[Hexagon] Don't build two halves of HVX vector in parallel" (authored by kparzysz).
Revert "[Hexagon] Don't build two halves of HVX vector in parallel"
Thu, Dec 30, 8:13 AM

Wed, Dec 29

kparzysz committed rGba07f300c6d6: [Hexagon] Don't build two halves of HVX vector in parallel (authored by kparzysz).
[Hexagon] Don't build two halves of HVX vector in parallel
Wed, Dec 29, 11:06 AM
kparzysz committed rG505d57486e57: [Hexagon] Improve BUILD_VECTOR codegen (authored by Joshua Herrera <joshherr@quicinc.com>).
[Hexagon] Improve BUILD_VECTOR codegen
Wed, Dec 29, 10:23 AM
kparzysz committed rG4df2aba294db: [Hexagon] Calling conventions for floating point vectors (authored by kparzysz).
[Hexagon] Calling conventions for floating point vectors
Wed, Dec 29, 9:02 AM
kparzysz committed rG2ce586bc497f: [Hexagon] Handle floating point splats (authored by kparzysz).
[Hexagon] Handle floating point splats
Wed, Dec 29, 6:53 AM
kparzysz committed rG33fc675e1670: [Hexagon] Handle floating point vector loads/stores (authored by kparzysz).
[Hexagon] Handle floating point vector loads/stores
Wed, Dec 29, 5:53 AM

Tue, Dec 28

kparzysz committed rG6a6ac3b36fcd: [Hexagon] Support BUILD_VECTOR of floating point HVX vectors (authored by kparzysz).
[Hexagon] Support BUILD_VECTOR of floating point HVX vectors
Tue, Dec 28, 3:01 PM
kparzysz committed rG7df136bcf258: [Hexagon] Delete unused declaration of LowerHvxMul, NFC (authored by kparzysz).
[Hexagon] Delete unused declaration of LowerHvxMul, NFC
Tue, Dec 28, 11:37 AM
kparzysz committed rGb05ed0d2cb8d: [Hexagon] Add testcase for arch flags (authored by androm3da).
[Hexagon] Add testcase for arch flags
Tue, Dec 28, 11:32 AM
kparzysz committed rG20135c8a5347: [Hexagon] Move testcase accidentally committed to wrong directory (authored by kparzysz).
[Hexagon] Move testcase accidentally committed to wrong directory
Tue, Dec 28, 11:22 AM
kparzysz committed rG1e7bd93ff2cc: [Hexagon] Add HexagonMCInstrInfo::IsABranchingInst, NFC (authored by androm3da).
[Hexagon] Add HexagonMCInstrInfo::IsABranchingInst, NFC
Tue, Dec 28, 9:54 AM
kparzysz committed rGc5327137df04: [Hexagon] Fix for producer operands search w/z-reg (authored by androm3da).
[Hexagon] Fix for producer operands search w/z-reg
Tue, Dec 28, 9:20 AM
kparzysz committed rG648246cce6a3: [Hexagon] Remove isPredicateRegister in favor of isPredReg, NFC (authored by kparzysz).
[Hexagon] Remove isPredicateRegister in favor of isPredReg, NFC
Tue, Dec 28, 8:42 AM

Thu, Dec 23

kparzysz committed rGa67c0fc1fbe8: [Hexagon] Revamp HVX flag verification in driver (authored by kparzysz).
[Hexagon] Revamp HVX flag verification in driver
Thu, Dec 23, 3:18 PM
kparzysz committed rG1d1b5efdef49: [Hexagon] Driver/preprocessor options for Hexagon v69 (authored by kparzysz).
[Hexagon] Driver/preprocessor options for Hexagon v69
Thu, Dec 23, 10:18 AM
kparzysz committed rG4c8becbeee18: [Hexagon] Add Hexagon v69 builtins to clang (authored by kparzysz).
[Hexagon] Add Hexagon v69 builtins to clang
Thu, Dec 23, 9:02 AM
kparzysz committed rGf766bc093c8c: [Hexagon] Introduce Hexagon v69 ISA (authored by kparzysz).
[Hexagon] Introduce Hexagon v69 ISA
Thu, Dec 23, 8:58 AM

Wed, Dec 22

kparzysz committed rGdcb3e8083a32: [Hexagon] Make conversions to vector predicate types explicit for builtins (authored by kparzysz).
[Hexagon] Make conversions to vector predicate types explicit for builtins
Wed, Dec 22, 12:52 PM

Dec 21 2021

kparzysz committed rG7a641d24997c: [Hexagon] Add ELF flags for Hexagon v69 (authored by kparzysz).
[Hexagon] Add ELF flags for Hexagon v69
Dec 21 2021, 8:51 AM

Dec 8 2021

kparzysz accepted D113638: [xray] Add support for hexagon architecture .

LGTM. Thanks!

Dec 8 2021, 11:26 AM · Restricted Project, Restricted Project, Restricted Project

Nov 22 2021

kparzysz accepted D114132: [NFC][llvm][Hexagon] Inclusive Terms remove uses of sanity in Hexagon taget.
Nov 22 2021, 6:31 AM · Restricted Project

Nov 19 2021

kparzysz added a comment to D114132: [NFC][llvm][Hexagon] Inclusive Terms remove uses of sanity in Hexagon taget.

Could you change the verification/validation to "basic correctness"? That would better reflect the intended meaning.

Nov 19 2021, 2:30 PM · Restricted Project

Nov 9 2021

kparzysz added a comment to D113150: Lift VLIWResourceModel, VLIWMachineScheduler, and ConvergingVLIWScheduler into CodeGen/VLIWMachineScheduler.

I committed a small patch (https://reviews.llvm.org/rGa721ddbae983), it changes releaseTopNode and releaseBottomNode, you'll need to rebase before merging.

Nov 9 2021, 9:51 AM · Restricted Project
kparzysz accepted D113150: Lift VLIWResourceModel, VLIWMachineScheduler, and ConvergingVLIWScheduler into CodeGen/VLIWMachineScheduler.

LGTM

Nov 9 2021, 9:47 AM · Restricted Project
kparzysz committed rGa721ddbae983: Update MaxMinLatency even if dependencies have been already scheduled. (authored by slarin).
Update MaxMinLatency even if dependencies have been already scheduled.
Nov 9 2021, 6:50 AM

Oct 20 2021

kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

The limitation is really that we can't reorder basic blocks after the BB sections pass. I've been thinking about it some more and I think we could move the packetization into pre-emit2. There weren't any other issues uncovered when I tried it locally.

Oct 20 2021, 9:14 AM · Restricted Project

Oct 15 2021

kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

I guess a flag DoNotVerify on the MF should be ok as well.

Oct 15 2021, 8:06 AM · Restricted Project
kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

The problem is that the packet rules can be target-specific (there are some very Hexagon-specific situations that are allowed/disallowed). I'd rather have an option to turn off the verifier on packetized code, than to make significant efforts to make the verifier work with it. We do have our own verification code in MC that validates packets, so the MIR verifier adds little value for us.

Oct 15 2021, 7:57 AM · Restricted Project

Oct 14 2021

kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

One problem that came up is that the "BB Sections" pass runs before pre-emit2. This imposes restrictions on what kinds of optimizations we can run in pre-emit2. If we could move BB Sections until after pre-emit2, it would be a lot better for us.

Oct 14 2021, 9:00 AM · Restricted Project

Oct 13 2021

kparzysz added inline comments to D111529: Specify Clang vector builtins..
Oct 13 2021, 2:28 PM · Restricted Project
kparzysz accepted D109117: [hexagon] Add system register, transfer support.

LGTM. Thanks!

Oct 13 2021, 11:25 AM · Restricted Project

Oct 8 2021

kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

That sounds reasonable. Let me try that locally (downstream). If it works, then let's do it.

Oct 8 2021, 11:42 AM · Restricted Project
kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

I guess you could add a target hook to TargetMachine to query whether the target wants to run the verifier at that stage, e.g.

addPass(createSomePreEmitPass(), TM->verifyCode(kPreEmit));

or something like that.

Oct 8 2021, 8:27 AM · Restricted Project
kparzysz added a comment to D111386: RFC: [Hexagon] Mark target as not "machine verifier clean".

There is nothing to fix in the packetizer. On Hexagon the order of instructions inside of packets generally doesn't matter (with a few exceptions). The verifier simply doesn't handle that, and that's why it's disabled.

Oct 8 2021, 8:13 AM · Restricted Project

Sep 24 2021

kparzysz added inline comments to D110182: [LiveIntervals] Find better anchoring end points when repairing ranges.
Sep 24 2021, 8:16 AM · Restricted Project

Sep 13 2021

kparzysz committed rG42dace9c5b5e: [Hexagon] Use getTypeAllocSize to compute difference between objects (authored by bcahoon).
[Hexagon] Use getTypeAllocSize to compute difference between objects
Sep 13 2021, 5:06 PM
kparzysz closed D109403: Few bug fixes in HexagonVectorCombine.
Sep 13 2021, 5:05 PM · Restricted Project
kparzysz closed D109623: [Hexagon] Handle Bitcast of i64/i128 -> v64i1/v128i1.

Committed in https://reviews.llvm.org/rGa72763af67a0.

Sep 13 2021, 4:54 PM · Restricted Project
kparzysz committed rGa72763af67a0: [Hexagon] Handle bitcast of i64/i128 -> v64i1/v128i1 (authored by aciidb0mb3r).
[Hexagon] Handle bitcast of i64/i128 -> v64i1/v128i1
Sep 13 2021, 4:53 PM
kparzysz accepted D109403: Few bug fixes in HexagonVectorCombine.
Sep 13 2021, 12:50 PM · Restricted Project
kparzysz accepted D109623: [Hexagon] Handle Bitcast of i64/i128 -> v64i1/v128i1.
Sep 13 2021, 11:44 AM · Restricted Project

Sep 10 2021

kparzysz accepted D109623: [Hexagon] Handle Bitcast of i64/i128 -> v64i1/v128i1.
Sep 10 2021, 1:31 PM · Restricted Project
kparzysz accepted D109604: [Hexagon] NFC: Remove unused tblgen template args.
Sep 10 2021, 10:49 AM · Restricted Project

Sep 1 2021

kparzysz accepted D109035: [TableGen][SelectionDAG] Use ComplexPattern type for non-leaf nodes.
Sep 1 2021, 11:18 AM · Restricted Project
kparzysz added a comment to D109035: [TableGen][SelectionDAG] Use ComplexPattern type for non-leaf nodes.

Edit: this comment is about AArch64. I didn't try to see if there are any other compilation errors.

Sep 1 2021, 11:04 AM · Restricted Project

Aug 18 2021

kparzysz accepted D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon.
Aug 18 2021, 11:46 AM · Restricted Project

Aug 5 2021

kparzysz committed rGd0c3b61498ec: Delay initialization of OptBisect (authored by kparzysz).
Delay initialization of OptBisect
Aug 5 2021, 7:05 AM
kparzysz closed D104551: Delay initialization of OptBisect.
Aug 5 2021, 7:04 AM · Restricted Project

Aug 2 2021

kparzysz added a comment to D105065: RegAlloc: Fix "SubRange for this mask not found" unreachable in SplitKit.

Ah, you're right, I didn't look closely enough.

Aug 2 2021, 11:18 AM · Restricted Project
kparzysz added a comment to D105065: RegAlloc: Fix "SubRange for this mask not found" unreachable in SplitKit.

Sorry, the emails that I'm getting from the @-mentions look exactly the same as any other email from phabricator to llvm-commits, and with hundreds of these per day I only look at a few...

Aug 2 2021, 10:43 AM · Restricted Project

Jul 30 2021

kparzysz updated the diff for D104551: Delay initialization of OptBisect.

Added definition of OptBisect::Disabled.

Jul 30 2021, 12:02 PM · Restricted Project
kparzysz updated the diff for D104551: Delay initialization of OptBisect.

Added resetting of the counter when new limit is set.

Jul 30 2021, 11:42 AM · Restricted Project

Jul 27 2021

kparzysz added inline comments to rG64d5b6e3737c: [Hexagon] Fix resetting dead registers in DBG_VALUE_LISTs.
Jul 27 2021, 5:18 PM
kparzysz added a comment to D104551: Delay initialization of OptBisect.

Yes, that's exactly what happens. The project uses LLVM as a code generator for multiple targets. The OptBisector object is constructed the first time it's queried by shouldRunPass, which happened during the code generation for the first target. We set up the second target by passing some extra flags to ParseCommandLineOptions, but passing -opt-bisect-limit at this time no longer has any effect (i.e. the setting from the construction time remains).

Jul 27 2021, 5:07 PM · Restricted Project
kparzysz added inline comments to rG64d5b6e3737c: [Hexagon] Fix resetting dead registers in DBG_VALUE_LISTs.
Jul 27 2021, 4:46 PM