Page MenuHomePhabricator

kparzysz (Krzysztof Parzyszek)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 21 2014, 4:27 PM (352 w, 2 d)

Recent Activity

Tue, Jan 19

kparzysz committed rG57443bfb4ab0: [Hexagon] Fix segment start to adjust for gaps between segments (authored by bcahoon).
[Hexagon] Fix segment start to adjust for gaps between segments
Tue, Jan 19, 10:55 AM

Thu, Jan 14

kparzysz accepted rG95019de8a122: [mlir][IR] Define the singleton builtin types in ODS instead of C++.

Mehdi has fixed this.

Thu, Jan 14, 8:16 AM

Wed, Jan 13

kparzysz closed D94607: [Hexagon] Improve legalizing of ISD::SETCC result.
Wed, Jan 13, 10:32 AM · Restricted Project
kparzysz accepted D94607: [Hexagon] Improve legalizing of ISD::SETCC result.

Committed in https://reviews.llvm.org/rGa2e6506c47b1.

Wed, Jan 13, 10:32 AM · Restricted Project
kparzysz added a comment to rGa90214760d04: [Hexagon] Custom-widen SETCC's operands.

Committed in https://reviews.llvm.org/rGa2e6506c47b1.

Wed, Jan 13, 10:31 AM
kparzysz committed rGa2e6506c47b1: [Hexagon] Improve legalizing of ISD::SETCC result (authored by kparzysz).
[Hexagon] Improve legalizing of ISD::SETCC result
Wed, Jan 13, 10:30 AM
kparzysz added a comment to rGa90214760d04: [Hexagon] Custom-widen SETCC's operands.

Could you try this patch? https://reviews.llvm.org/D94607

Wed, Jan 13, 8:33 AM
kparzysz requested review of D94607: [Hexagon] Improve legalizing of ISD::SETCC result.
Wed, Jan 13, 8:32 AM · Restricted Project
kparzysz added a comment to rGa90214760d04: [Hexagon] Custom-widen SETCC's operands.

Thanks for the report, looking into it.

Wed, Jan 13, 7:30 AM

Mon, Jan 11

kparzysz committed rGa90214760d04: [Hexagon] Custom-widen SETCC's operands (authored by kparzysz).
[Hexagon] Custom-widen SETCC's operands
Mon, Jan 11, 10:29 AM

Wed, Jan 6

kparzysz committed rG46975b5b29e2: [Hexagon] Wrap functions only used in asserts in ifndef NDEBUG (authored by kparzysz).
[Hexagon] Wrap functions only used in asserts in ifndef NDEBUG
Wed, Jan 6, 7:41 AM

Tue, Jan 5

kparzysz committed rGee11bf316f6b: [Hexagon] Silence unused function warning with gcc10, NFC (authored by kparzysz).
[Hexagon] Silence unused function warning with gcc10, NFC
Tue, Jan 5, 12:12 PM

Mon, Jan 4

kparzysz committed rGc55b609b777d: [Hexagon] Fix bad SDNodeXForm (authored by kparzysz).
[Hexagon] Fix bad SDNodeXForm
Mon, Jan 4, 8:43 AM

Dec 16 2020

kparzysz raised a concern with rG95019de8a122: [mlir][IR] Define the singleton builtin types in ODS instead of C++.

This commit broke compilation of debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp. The compile command for this file doesn't get the path to the tblgen-generated includes, and it fails with

In file included from /w/src/llvm.org/debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp:2:
/w/src/llvm.org/llvm/../mlir/include/mlir/IR/BuiltinTypes.h:638:10: fatal error: 'mlir/IR/BuiltinTypes.h.inc' file not found
#include "mlir/IR/BuiltinTypes.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Dec 16 2020, 8:26 AM

Dec 15 2020

kparzysz committed rG0f903015c774: [Hexagon] Rename test case, NFC (authored by kparzysz).
[Hexagon] Rename test case, NFC
Dec 15 2020, 5:07 PM
kparzysz committed rGfe0527e1c7e4: [Hexagon] Temporarily disable vector realignment for non-HVX vectors (authored by kparzysz).
[Hexagon] Temporarily disable vector realignment for non-HVX vectors
Dec 15 2020, 5:04 PM
kparzysz committed rG16385643bbf2: [Hexagon] Emit enough stores when aligning vector addresses (authored by kparzysz).
[Hexagon] Emit enough stores when aligning vector addresses
Dec 15 2020, 5:01 PM
kparzysz committed rG71601d2ac995: [Hexagon] Fix bitcasting v1i8 -> i8 (authored by kparzysz).
[Hexagon] Fix bitcasting v1i8 -> i8
Dec 15 2020, 2:02 PM

Dec 12 2020

kparzysz committed rGbaf931a8427d: [Hexagon] Reconsider getMask fix, return original mask, convert later (authored by kparzysz).
[Hexagon] Reconsider getMask fix, return original mask, convert later
Dec 12 2020, 11:30 AM
kparzysz committed rG2cf53104711e: [Hexagon] Create vector masks for scalar loads/stores (authored by kparzysz).
[Hexagon] Create vector masks for scalar loads/stores
Dec 12 2020, 9:12 AM

Dec 11 2020

kparzysz committed rG2d8cc5479b9e: [Hexagon] Workaround for compilation error with VS2017 (authored by kparzysz).
[Hexagon] Workaround for compilation error with VS2017
Dec 11 2020, 1:12 PM

Dec 10 2020

kparzysz added inline comments to rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible.
Dec 10 2020, 6:23 AM
kparzysz committed rG7c9afe9183ee: [Hexagon] Fix gcc6 compilation issue (authored by kparzysz).
[Hexagon] Fix gcc6 compilation issue
Dec 10 2020, 6:19 AM

Dec 9 2020

kparzysz committed rGe3b2828b9d6d: [Hexagon] Silence warnings about unused objects (authored by kparzysz).
[Hexagon] Silence warnings about unused objects
Dec 9 2020, 3:56 PM
kparzysz committed rG43d1c7a56453: [Hexagon] Fix build: move template specialization into namespace scope (authored by kparzysz).
[Hexagon] Fix build: move template specialization into namespace scope
Dec 9 2020, 3:40 PM
kparzysz committed rGf5d07a05bbd4: [Hexagon] Realign HVX vectors wherever possible (authored by kparzysz).
[Hexagon] Realign HVX vectors wherever possible
Dec 9 2020, 3:12 PM

Dec 4 2020

kparzysz committed rG1b404ad51e93: Include BuiltinAttributes.h in llvm-prettyprinters/gdb/mlir-support.cpp (authored by kparzysz).
Include BuiltinAttributes.h in llvm-prettyprinters/gdb/mlir-support.cpp
Dec 4 2020, 1:59 PM

Nov 27 2020

kparzysz committed rGb7bde0e4f3d2: [Hexagon] Improve check for HVX types (authored by kparzysz).
[Hexagon] Improve check for HVX types
Nov 27 2020, 11:36 AM
kparzysz accepted D92169: [Hexagon] Add HVX support for ISD::SMAX/SMIN/UMAX/UMIN instead of custom dag patterns.

LGTM, Thanks!

Nov 27 2020, 6:52 AM · Restricted Project

Nov 25 2020

kparzysz accepted D92112: [Hexagon] Add support for ISD::SMAX/SMIN/UMAX/UMIN instead of custom dag patterns.
Nov 25 2020, 9:54 AM · Restricted Project
kparzysz added a comment to D92112: [Hexagon] Add support for ISD::SMAX/SMIN/UMAX/UMIN instead of custom dag patterns.

Looks great! Thank you for doing this.

Nov 25 2020, 9:53 AM · Restricted Project

Nov 23 2020

kparzysz added inline comments to D90973: [RISCV] Remove RV32 HwMode. Use DefaultMode for RV32.
Nov 23 2020, 8:30 AM · Restricted Project

Nov 20 2020

kparzysz added inline comments to D90973: [RISCV] Remove RV32 HwMode. Use DefaultMode for RV32.
Nov 20 2020, 2:00 PM · Restricted Project
kparzysz accepted D91829: [Hexagon][NewPM] Port -hexagon-loop-idiom and add to pipeline.

LGTM. Thanks!

Nov 20 2020, 9:08 AM · Restricted Project

Nov 19 2020

kparzysz added a comment to D90973: [RISCV] Remove RV32 HwMode. Use DefaultMode for RV32.

Sorry, I just noticed this now. Yes, this does make perfect sense. As a matter of fact, I've been thinking of reorganizing the "default mode" to be something that does not need an explicit entry.

Nov 19 2020, 5:36 AM · Restricted Project

Nov 2 2020

kparzysz committed rGb26a2755dc10: [Hexagon] Move isTypeForHVX from Hexagon TTI to HexagonSubtarget, NFC (authored by kparzysz).
[Hexagon] Move isTypeForHVX from Hexagon TTI to HexagonSubtarget, NFC
Nov 2 2020, 12:01 PM

Oct 29 2020

kparzysz committed rGdb60e64036d1: [Hexagon] Handle additional shuffles that can be made perfect (authored by kparzysz).
[Hexagon] Handle additional shuffles that can be made perfect
Oct 29 2020, 5:09 PM

Oct 23 2020

kparzysz committed rG1b5baa42bc93: [Hexagon] Handle selection between HVX vector predicates (authored by kparzysz).
[Hexagon] Handle selection between HVX vector predicates
Oct 23 2020, 4:22 PM

Oct 16 2020

kparzysz committed rG97533b10b27d: [Hexagon] Fix license headers in some .td files, NFC (authored by kparzysz).
[Hexagon] Fix license headers in some .td files, NFC
Oct 16 2020, 8:03 AM

Oct 14 2020

kparzysz committed rG670cd3c6e324: [Hexagon] Generate better splat code on v62+ (authored by kparzysz).
[Hexagon] Generate better splat code on v62+
Oct 14 2020, 10:56 AM

Oct 10 2020

kparzysz committed rG9237e73ae8a3: [Hexagon] Replace HexagonISD::VSPLAT with ISD::SPLAT_VECTOR (authored by kparzysz).
[Hexagon] Replace HexagonISD::VSPLAT with ISD::SPLAT_VECTOR
Oct 10 2020, 5:52 PM
kparzysz committed rG61eaa2e14aed: [SDAG] Remember to set UndefElts in isSplatValue for SPLAT_VECTOR (authored by kparzysz).
[SDAG] Remember to set UndefElts in isSplatValue for SPLAT_VECTOR
Oct 10 2020, 5:52 PM
kparzysz committed rG4af6c6bf3c28: Define splat_vector for ISD::SPLAT_VECTOR in TargetSelectionDAG.td (authored by kparzysz).
Define splat_vector for ISD::SPLAT_VECTOR in TargetSelectionDAG.td
Oct 10 2020, 11:12 AM

Oct 9 2020

kparzysz committed rG6fd994b4b7ac: [Hexagon] Remove ISD node VSPLATW, use VSPLAT instead (authored by kparzysz).
[Hexagon] Remove ISD node VSPLATW, use VSPLAT instead
Oct 9 2020, 1:38 PM
kparzysz committed rG33bb3efbb34b: [Hexagon] Generalize handling of SDNodes created during ISel (authored by kparzysz).
[Hexagon] Generalize handling of SDNodes created during ISel
Oct 9 2020, 1:38 PM
kparzysz added inline comments to D87679: [LV] Unroll factor is expected to be > 0.
Oct 9 2020, 7:48 AM · Restricted Project
kparzysz committed rG99cafe009477: [Hexagon] Return 1 instead of 0 from getMaxInterleaveFactor (authored by kparzysz).
[Hexagon] Return 1 instead of 0 from getMaxInterleaveFactor
Oct 9 2020, 7:46 AM

Oct 2 2020

kparzysz committed rGf528816d586a: [Hexagon] Move selection of HVX multiply from lowering to patterns (authored by kparzysz).
[Hexagon] Move selection of HVX multiply from lowering to patterns
Oct 2 2020, 2:05 PM

Sep 30 2020

kparzysz closed D88273: [SDAG] Do not convert undef to 0 when folding CONCAT/BUILD_VECTOR.

Committed in db04bec5f1eeb581ee1470e5f444cc7b918c6d93. Somehow phabricator missed it and didn't close automatically.

Sep 30 2020, 6:46 AM · Restricted Project

Sep 25 2020

kparzysz added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

I think I'm still missing how exactly this will fit into the pipeline. As in where is registerPassBuilderCallbacks() going to be called?

Sep 25 2020, 12:13 PM · Restricted Project, Restricted Project
kparzysz added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

My understanding is that this API gives other applications chance to modify the pass pipeline.

Sep 25 2020, 12:06 PM · Restricted Project, Restricted Project

Sep 24 2020

kparzysz requested review of D88273: [SDAG] Do not convert undef to 0 when folding CONCAT/BUILD_VECTOR.
Sep 24 2020, 6:23 PM · Restricted Project
kparzysz committed rG3185839bcf66: [Hexagon] Avoid crash on CONCAT_VECTORS with illegal element types (authored by kparzysz).
[Hexagon] Avoid crash on CONCAT_VECTORS with illegal element types
Sep 24 2020, 6:06 PM
kparzysz accepted D88020: [SplitKit] In addDeadDef tolerate parent range that defines more lanes.

You're right, it goes in the other direction. Looks ok to me.

Sep 24 2020, 7:15 AM · Restricted Project

Sep 23 2020

kparzysz added a comment to D88020: [SplitKit] In addDeadDef tolerate parent range that defines more lanes.

I don't think it's safe to add dead defs to the extra lanes. You could split the superset into the matching part and the remaining part, then only operate on the matching one.

Sep 23 2020, 5:23 PM · Restricted Project
kparzysz added inline comments to rGe976fb1e54f3: [EarlyCSE] Fix crash with expensive checks after D87691.
Sep 23 2020, 1:38 PM
kparzysz committed rG57f097420d43: Clean up test file, NFC (authored by kparzysz).
Clean up test file, NFC
Sep 23 2020, 1:36 PM
kparzysz added a comment to rGe976fb1e54f3: [EarlyCSE] Fix crash with expensive checks after D87691.

We should probably change bugpoint to stop using undef everywhere.

Sep 23 2020, 11:31 AM
kparzysz added a comment to D87691: [EarlyCSE] Small refactoring changes, NFC.

Fixed in https://reviews.llvm.org/rGe976fb1e54f3.

Sep 23 2020, 10:26 AM · Restricted Project
kparzysz committed rG76e8c1899e7c: Break long line accidentally left in the previous commit (authored by kparzysz).
Break long line accidentally left in the previous commit
Sep 23 2020, 10:25 AM
kparzysz committed rGe976fb1e54f3: [EarlyCSE] Fix crash with expensive checks after D87691 (authored by kparzysz).
[EarlyCSE] Fix crash with expensive checks after D87691
Sep 23 2020, 10:22 AM
kparzysz added a comment to D87691: [EarlyCSE] Small refactoring changes, NFC.

It would be great if you could take a look or revert if it takes longer to fix.

Sure, let me check.

Sep 23 2020, 9:01 AM · Restricted Project
kparzysz added a comment to D87691: [EarlyCSE] Small refactoring changes, NFC.

It would be great if you could take a look or revert if it takes longer to fix.

Sep 23 2020, 6:09 AM · Restricted Project

Sep 21 2020

kparzysz committed rGae3f54c1e909: [EarlyCSE] Handle masked loads and stores (authored by kparzysz).
[EarlyCSE] Handle masked loads and stores
Sep 21 2020, 4:47 PM
kparzysz closed D87340: [EarlyCSE] Handle masked loads and stores.
Sep 21 2020, 4:47 PM · Restricted Project
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Removed unnecessary checks in isSubmask.

Sep 21 2020, 4:40 PM · Restricted Project
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Fixed submask detection.

Sep 21 2020, 2:31 PM · Restricted Project
kparzysz committed rG2c768c7d6c61: [EarlyCSE] Small refactoring changes, NFC (authored by kparzysz).
[EarlyCSE] Small refactoring changes, NFC
Sep 21 2020, 2:11 PM
kparzysz closed D87691: [EarlyCSE] Small refactoring changes, NFC.
Sep 21 2020, 2:11 PM · Restricted Project

Sep 18 2020

kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Pre-committed new test file.

Sep 18 2020, 12:54 PM · Restricted Project
kparzysz committed rGae0ecb3c505e: Pre-commit test for CSEing masked loads/stores (authored by kparzysz).
Pre-commit test for CSEing masked loads/stores
Sep 18 2020, 12:31 PM
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Add testcases with unequal masks.

Sep 18 2020, 12:12 PM · Restricted Project
kparzysz added inline comments to D87340: [EarlyCSE] Handle masked loads and stores.
Sep 18 2020, 12:11 PM · Restricted Project
kparzysz updated the diff for D87691: [EarlyCSE] Small refactoring changes, NFC.

Removed the bool argument to getMatchingValue. Added comments explaining how the return value is used.

Sep 18 2020, 8:09 AM · Restricted Project
kparzysz added inline comments to D87691: [EarlyCSE] Small refactoring changes, NFC.
Sep 18 2020, 8:03 AM · Restricted Project

Sep 16 2020

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Thank you both @srj and @pranavb for your help!

Sep 16 2020, 12:37 PM

Sep 15 2020

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Should be fixed in https://reviews.llvm.org/rG5f4abb7fab1c.

Sep 15 2020, 6:37 PM
kparzysz committed rG5f4abb7fab1c: [Hexagon] Replace incorrect pattern for vpackl HWI32 -> HVi8 (authored by kparzysz).
[Hexagon] Replace incorrect pattern for vpackl HWI32 -> HVi8
Sep 15 2020, 6:35 PM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

The machine instructions in both dumps are identical... There are differences in addresses that are printed in the dump, and in the names of some values in the LLVM IR, but the machine instructions are the same.

Sep 15 2020, 11:52 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

The LLVM ERROR: Do not know how to split the result of this operator! happens when a function with an HVX intrinsic is compiled without +hvx,+hvx-length... attributes.

Sep 15 2020, 11:24 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

I added it to attributes #0, #1, #3 and #4.

Sep 15 2020, 11:23 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

If you have the ability to pass LLVM options, could you get the good and bad outputs with -debug-only=isel,legalize-types,legalizedag -print-after-all?

Sep 15 2020, 10:34 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Just llc -march=hexagon < bad_hvx64_code.ll, but I added "target-cpu"="hexagonv65" "target-features"="+hvx,+hvx-length64b" to attributes inside the file.

Sep 15 2020, 10:25 AM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

It may well still be too hard to debug with what I've given you -- let me know if it needs to be simplified further.

Sep 15 2020, 10:09 AM
kparzysz updated the diff for D87340: [EarlyCSE] Handle masked loads and stores.

Rebased on top of D87691.

Sep 15 2020, 8:08 AM · Restricted Project
kparzysz added a comment to D87340: [EarlyCSE] Handle masked loads and stores.

Created D87691 with the refactoring. Will rebase this patch soon.

Sep 15 2020, 6:59 AM · Restricted Project
kparzysz requested review of D87691: [EarlyCSE] Small refactoring changes, NFC.
Sep 15 2020, 6:58 AM · Restricted Project

Sep 14 2020

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Great, thanks! Will take a look tomorrow.

Sep 14 2020, 4:50 PM
kparzysz committed rGf35617ad809b: [Hexagon] Add more detailed testcase for widening truncates (authored by kparzysz).
[Hexagon] Add more detailed testcase for widening truncates
Sep 14 2020, 4:13 PM
kparzysz committed rGbb877d1af2ec: [Hexagon] Widen loads and handle any-/sign-/zero-extensions (authored by kparzysz).
[Hexagon] Widen loads and handle any-/sign-/zero-extensions
Sep 14 2020, 4:11 PM
kparzysz committed rG6352381039c4: [Hexagon] Some HVX DAG combines (authored by kparzysz).
[Hexagon] Some HVX DAG combines
Sep 14 2020, 4:11 PM
kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Do you know what vector types are involved (e.g. <32 x i8>)? Anything with i1 or i64?

Sep 14 2020, 2:54 PM
kparzysz added a comment to D87340: [EarlyCSE] Handle masked loads and stores.

This should be NFC for everything that doesn't involve masked loads/stores.

Sep 14 2020, 6:14 AM · Restricted Project

Sep 12 2020

kparzysz committed rG9d300bc8d2f3: [Hexagon] Avoid widening vectors with non-HVX element types (authored by kparzysz).
[Hexagon] Avoid widening vectors with non-HVX element types
Sep 12 2020, 6:30 PM

Sep 11 2020

kparzysz added a comment to rG0ee54cf88329: [Hexagon] Account for truncating pairs to non-pairs when widening truncates.

Sure. Keep me posted.

Sep 11 2020, 5:34 PM
kparzysz committed rGf92908cc749e: [DSE] Make sure that DSE+MSSA can handle masked stores (authored by kparzysz).
[DSE] Make sure that DSE+MSSA can handle masked stores
Sep 11 2020, 8:01 AM
kparzysz closed D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.
Sep 11 2020, 8:00 AM · Restricted Project
kparzysz added inline comments to D87414: [DSE] Make sure that DSE+MSSA can handle masked stores.
Sep 11 2020, 7:20 AM · Restricted Project

Sep 10 2020

kparzysz committed rG783e28a50839: [Hexagon] Split pair-based masked memops (authored by kparzysz).
[Hexagon] Split pair-based masked memops
Sep 10 2020, 12:25 PM
kparzysz committed rG8a08740db6e1: [GVN] Account for masked loads/stores depending on load/store instructions (authored by kparzysz).
[GVN] Account for masked loads/stores depending on load/store instructions
Sep 10 2020, 8:58 AM