This is an archive of the discontinued LLVM Phabricator instance.

Differential D20188

Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
ClosedPublic

Authored by krytarowski on May 11 2016, 4:32 PM.

Details

Reviewers
emaste
clayborg
Commits
rGeab80e585696: Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
rLLDB269330: Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
rL269330: Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
Summary

The editline(3) library in NetBSD is by default internally wide.

Diff Detail

Event Timeline

krytarowski updated this revision to Diff 56982.May 11 2016, 4:32 PM
krytarowski retitled this revision from to Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD.
krytarowski updated this object.
krytarowski added reviewers: emaste, clayborg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added subscribers: lldb-commits, joerg.
clayborg accepted this revision.May 11 2016, 5:00 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.May 11 2016, 5:00 PM
emaste added inline comments.May 11 2016, 6:15 PM
include/lldb/Host/Editline.h
33

Perhaps just some platforms? It doesn't make sense to repeat the list of #if defined conditions in the comment.

krytarowski updated this revision to Diff 57011.May 12 2016, 3:02 AM
krytarowski edited edge metadata.
krytarowski removed rL LLVM as the repository for this revision.

I changed the string to "some platforms".

emaste accepted this revision.EditedMay 12 2016, 6:02 AM
emaste edited edge metadata.

Thanks.

(The reason I mentioned it is that I'll add __FreeBSD__ shortly.)

krytarowski closed this revision.May 12 2016, 12:52 PM

Revision Contents

PathSize
include/
lldb/
Host/
5 lines

Diff 57011

include/lldb/Host/Editline.h

Show All 21 Lines
// e) Emoji support is fairly terrible, presumably it doesn't understand composed characters? // e) Emoji support is fairly terrible, presumably it doesn't understand composed characters?
#ifndef liblldb_Editline_h_ #ifndef liblldb_Editline_h_
#define liblldb_Editline_h_ #define liblldb_Editline_h_
#if defined(__cplusplus) #if defined(__cplusplus)
#include <sstream> #include <sstream>
#include <vector> #include <vector>
#include <locale>
// components needed to handle wide characters ( <codecvt>, codecvt_utf8, libedit built with '--enable-widec' ) // components needed to handle wide characters ( <codecvt>, codecvt_utf8, libedit built with '--enable-widec' )
// are not consistenly available on non-OSX platforms. The wchar_t versions of libedit functions will only be // are available on some platforms. The wchar_t versions of libedit functions will only be
emasteUnsubmitted
Not Done
ReplyInline Actions

Perhaps just some platforms? It doesn't make sense to repeat the list of #if defined conditions in the comment.

emaste: Perhaps just `some platforms`? It doesn't make sense to repeat the list of `#if defined`…
// used in cases where this is true. This is a compile time dependecy, for now selected per target Platform // used in cases where this is true. This is a compile time dependecy, for now selected per target Platform
#if defined (__APPLE__) #if defined (__APPLE__) || defined(__NetBSD__)
#define LLDB_EDITLINE_USE_WCHAR 1 #define LLDB_EDITLINE_USE_WCHAR 1
#include <codecvt> #include <codecvt>
#else #else
#define LLDB_EDITLINE_USE_WCHAR 0 #define LLDB_EDITLINE_USE_WCHAR 0
#endif #endif
#include "lldb/lldb-private.h" #include "lldb/lldb-private.h"
#include "lldb/Host/ConnectionFileDescriptor.h" #include "lldb/Host/ConnectionFileDescriptor.h"
▲ Show 20 Lines • Show All 324 Lines • Show Last 20 Lines