Fix relocation problem when handling end section for Win x86

[wallace]

Summary

In the block in line 72, a dummy relocation entry is added for the end iterator. This is causing a problem because it has a relocation type that, for instance, if it is IMAGE_REL_I386_REL32, will try to be resolved later in the resolveRelocation function, which breaks some calculations because this dummy entry has invalid values, specifically the sectionA, which is -1.

Thus, I'm changing the relocation type to absolute, which in fact does no calculations.

However, I think that it might make sense not to include this dummy relocation entry. Removing it works with what i try to debug, but I don't know all the implications of this.

[compnerd]

Please add a test case for this.

[wallace]

This comment was removed by wallace.

[wallace]

I've changed the approach

[compnerd]

I think I prefer the original approach over this. This changes the internal representation of the relocation which makes it slightly harder to trace through. The original approach with a test case would be preferable. But, this still needs a test case.

[wallace]

sadly i don't know which asm code can trigger this relocation type :(

lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFI386.h

 
     unsigned TargetSectionID = -1;
     if (Section == Obj.section_end()) {
-      RelocationEntry RE(SectionID, Offset, RelType, 0, -1, 0, 0, 0, false, 0);
+      RelocationEntry RE(SectionID, Offset, COFF::IMAGE_REL_I386_ABSOLUTE, 0,
+                         -1, 0, 0, 0, false, 0);
       addRelocationForSymbol(RE, TargetName);
     } else {
       if (auto TargetSectionIDOrErr =