Page MenuHomePhabricator

wallace (walter erquinigo)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2016, 10:57 AM (297 w, 3 d)

Recent Activity

Fri, Jan 14

wallace accepted D117288: [LLDB][NFC] Fix a typo in comment.

Thanks!

Fri, Jan 14, 5:54 AM · Restricted Project

Wed, Jan 5

wallace updated the diff for D115974: [formatters] Improve documentation.

per comments

Wed, Jan 5, 12:10 PM · Restricted Project

Dec 21 2021

wallace accepted D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled..

lgtm

Dec 21 2021, 11:38 AM · Restricted Project
wallace added a comment to D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected..

thanks for doing this. Just a few minor comments and i think this is good to go

Dec 21 2021, 11:37 AM · Restricted Project

Dec 17 2021

wallace requested review of D115974: [formatters] Improve documentation.
Dec 17 2021, 3:01 PM · Restricted Project
wallace added inline comments to D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled..
Dec 17 2021, 1:17 PM · Restricted Project

Dec 14 2021

wallace accepted D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster..

lgtm

Dec 14 2021, 7:36 AM · Restricted Project

Dec 13 2021

wallace requested changes to D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster..

much nicer than the first version. I'm just asking a few minor things.

Dec 13 2021, 4:36 PM · Restricted Project

Dec 9 2021

wallace added a comment to D115178: Unify libstdcpp and libcxx formatters for `std::optional`.

committed as cfb075089128b2e5918afd0ce21ec10bf455e5ab

Dec 9 2021, 1:11 PM · Restricted Project
wallace closed D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

committed as 2ea3c8a50add5436cf939d59c3235408ca0255c1

Dec 9 2021, 12:21 PM · Restricted Project

Dec 8 2021

wallace accepted D115178: Unify libstdcpp and libcxx formatters for `std::optional`.

great job!

Dec 8 2021, 9:54 AM · Restricted Project

Dec 6 2021

wallace requested changes to D115178: Unify libstdcpp and libcxx formatters for `std::optional`.
Dec 6 2021, 3:08 PM · Restricted Project
wallace added a comment to D115178: Unify libstdcpp and libcxx formatters for `std::optional`.

good job! Only some cosmetic changes are needed and you also need to delete the python code

Dec 6 2021, 3:07 PM · Restricted Project
wallace requested changes to D115178: Unify libstdcpp and libcxx formatters for `std::optional`.

back to your queue until you get things working

Dec 6 2021, 1:41 PM · Restricted Project
wallace accepted D115137: [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx.

thank you!

Dec 6 2021, 12:40 PM · Restricted Project

Dec 3 2021

wallace accepted D115033: [lldb-vscode] Report supportsModulesRequest=true.

Thanks!

Dec 3 2021, 6:59 AM · Restricted Project

Dec 2 2021

wallace retitled D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one from Draft PR for the deque, stack, queue lldb data formatters to [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.
Dec 2 2021, 5:56 PM · Restricted Project
wallace updated the diff for D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

Fix the few issues in Danil's implementation

Dec 2 2021, 5:55 PM · Restricted Project
wallace commandeered D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.
Dec 2 2021, 5:52 PM · Restricted Project

Nov 23 2021

wallace accepted D114433: [formatters] List and forward_list capping_size determination and application.
Nov 23 2021, 1:45 PM · Restricted Project
wallace accepted D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters..

great!!!

Nov 23 2021, 11:15 AM · Restricted Project
wallace updated the diff for D114458: Make some libstd++ formatters safer.

labath's comment

Nov 23 2021, 11:13 AM · Restricted Project
wallace added inline comments to D114458: Make some libstd++ formatters safer.
Nov 23 2021, 10:53 AM · Restricted Project
wallace updated the diff for D114450: Improve optional formatter.

fix the issue when both formatters run together and apply labath's suggestion

Nov 23 2021, 10:52 AM · Restricted Project
wallace requested changes to D114433: [formatters] List and forward_list capping_size determination and application.

add generic tests for list

Nov 23 2021, 10:45 AM · Restricted Project
wallace added a comment to D114450: Improve optional formatter.

That said, I'm more worried about the strange interactions between libc++ and libstdc++ formatters I reported.

Nov 23 2021, 10:17 AM · Restricted Project
wallace added a reviewer for D114458: Make some libstd++ formatters safer: danilashtefan.
Nov 23 2021, 10:13 AM · Restricted Project
wallace requested review of D114458: Make some libstd++ formatters safer.
Nov 23 2021, 10:13 AM · Restricted Project
wallace abandoned D114266: [formatters] Draft Optional PR.
Nov 23 2021, 9:23 AM · Restricted Project
wallace commandeered D114266: [formatters] Draft Optional PR.
Nov 23 2021, 9:23 AM · Restricted Project
wallace requested review of D114450: Improve optional formatter.
Nov 23 2021, 9:19 AM · Restricted Project
wallace requested changes to D114433: [formatters] List and forward_list capping_size determination and application.
Nov 23 2021, 8:42 AM · Restricted Project

Nov 22 2021

wallace updated the diff for D114403: [formatters] Add a formatter for libstdc++ optional.

nit

Nov 22 2021, 3:36 PM · Restricted Project
wallace added a reviewer for D114403: [formatters] Add a formatter for libstdc++ optional: danilashtefan.
Nov 22 2021, 3:33 PM · Restricted Project
wallace requested review of D114403: [formatters] Add a formatter for libstdc++ optional.
Nov 22 2021, 3:33 PM · Restricted Project

Nov 17 2021

wallace accepted D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

good job!

Nov 17 2021, 1:07 PM · Restricted Project
wallace requested changes to D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.
Nov 17 2021, 12:58 PM · Restricted Project
wallace requested changes to D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one.

discussed offline how to traverse each individual subarray. This might make it impossible to reuse it for queue and stack

Nov 17 2021, 8:26 AM · Restricted Project
wallace requested changes to D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

just some minor changes.
Could you unify these tests with libcxx?

Nov 17 2021, 8:13 AM · Restricted Project

Nov 13 2021

wallace added a reviewer for D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset: clayborg.
Nov 13 2021, 7:56 AM · Restricted Project

Nov 12 2021

wallace requested changes to D113789: Add the ability to cache information for a module between debugger instances..

There are two things that could be added. One is already mentioned in the comments, which is logging error messages in a way that we can track bugs in an automated fashion, as right now the errors are being thrown away or transformed into simple true/false values that lose the information of the actual issue. Now that we have a rich telemetry in place, we should use llvm::Error/Expected as much as possible and log the errors in both a log channel and the target stats. The second item to discuss is that there should be a configurable maximum size of the entire cache folder (e.g. 70GB), so that, for example, when lldb initializes it cleans up the oldest items that make the cache blow up. I can also add telemetry from the IDE side to track the size of the total cache folder, but I imagine that if we don't put a limiter, we might cause some issues.

Nov 12 2021, 10:04 PM · Restricted Project
wallace accepted D113810: Add the stop count to "statistics dump" in each target's dictionary..
Nov 12 2021, 8:59 PM · Restricted Project
wallace requested changes to D113760: [formatters] Add a libstdcpp formatter for for unordered_map, unordered_set, unordered_multimap, unordered_multiset.

When you do your tests, don't care too much about std::string yet, as it has its own issues, but instead create a non-standard size type like

Nov 12 2021, 9:54 AM · Restricted Project

Nov 9 2021

wallace accepted D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

thanks!

Nov 9 2021, 11:13 AM · Restricted Project
wallace updated subscribers of D113400: [lldb-vscode] Add presentation hints for scopes.

Cool. I hope that vscode catches up.

Nov 9 2021, 8:34 AM · Restricted Project

Nov 8 2021

wallace requested changes to D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

Much better. Just some better patterns that you could follow. Read my comments.

Nov 8 2021, 11:36 PM · Restricted Project
wallace accepted D113400: [lldb-vscode] Add presentation hints for scopes.

could you share a screenshot of how this looks like?

Nov 8 2021, 11:14 PM · Restricted Project
wallace added a comment to D110804: Add a new command "target metrics"..

is this going to be abandoned?

Nov 8 2021, 11:13 PM · Restricted Project

Nov 7 2021

wallace requested changes to D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter.

very good start!

Nov 7 2021, 10:20 AM · Restricted Project

Nov 1 2021

wallace added a comment to D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types.
Nov 1 2021, 10:10 PM · Restricted Project

Oct 30 2021

wallace accepted D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs.

good job

Oct 30 2021, 2:47 PM · Restricted Project
wallace added a comment to D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types.

@xujuntwt95329 do you have push permissions or do you need help to land this diff?

Oct 30 2021, 1:57 PM · Restricted Project
wallace accepted D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.

thanks! i'll land this now

Oct 30 2021, 12:50 PM · Restricted Project

Oct 29 2021

wallace accepted D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types.

thanks!

Oct 29 2021, 10:21 PM · Restricted Project
wallace accepted D112834: [lldb-vscode] Fix coredump load source mapping for first file.

thanks!

Oct 29 2021, 10:14 PM · Restricted Project
wallace requested changes to D112785: [formatters] Add a libstdcpp formatter for multiset and unify tests across stdlibs.

let's land https://reviews.llvm.org/D112752 first and then this one

Oct 29 2021, 7:22 PM · Restricted Project
wallace requested changes to D112752: [formatters] Add a libstdcpp formatter for multimap and unify modify tests across stdlibs.

pretty good, just cosmetic changes and a comment update needed

Oct 29 2021, 7:19 PM · Restricted Project

Oct 27 2021

wallace accepted D112683: Add unix signal hit counts to the target statistics..

great!

Oct 27 2021, 8:32 PM · Restricted Project
wallace accepted D112587: Add breakpoint resolving stats to each target..

sounds good to me!

Oct 27 2021, 4:37 PM · Restricted Project
wallace accepted D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Just fix that last thing and I'll land your patch :) Thanks

Oct 27 2021, 11:22 AM · Restricted Project
wallace added inline comments to D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.
Oct 27 2021, 9:46 AM · Restricted Project
wallace requested changes to D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

pretty good! Just some cosmetic changes needed and that's it

Oct 27 2021, 9:09 AM · Restricted Project

Oct 26 2021

wallace requested changes to D112587: Add breakpoint resolving stats to each target..
Oct 26 2021, 9:47 PM · Restricted Project
wallace added a comment to D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

Pushed upstream as 566bfbb740bb0ffef827ce983d7aa899236fcb88

Oct 26 2021, 2:50 PM · Restricted Project
wallace accepted D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

great! I'll land it for you

Oct 26 2021, 2:23 PM · Restricted Project
wallace added a comment to D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

Besides, given that you are using the same python implementation for map and set, better rename the class to StdSeOrMapSynthProvider and add a comment mentioning that it works both for set and maps because they have the same underlying structure

Oct 26 2021, 2:19 PM · Restricted Project
wallace added a comment to D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

just some minor things left

Oct 26 2021, 2:18 PM · Restricted Project
wallace retitled D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs from Set synthetic children to [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.
Oct 26 2021, 2:06 PM · Restricted Project
wallace retitled D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs from [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs to [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 26 2021, 1:52 PM · Restricted Project
wallace requested changes to D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

I think you messed up when updating the diffs. I don't see the bitset diff anymore.

Oct 26 2021, 9:11 AM · Restricted Project
wallace requested changes to D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.

I think you messed up when updating the diffs. I don't see the bitset diff anymore.

Oct 26 2021, 9:11 AM · Restricted Project
wallace updated the summary of D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 26 2021, 9:06 AM · Restricted Project
wallace retitled D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs from [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs to [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs.
Oct 26 2021, 9:05 AM · Restricted Project
wallace retitled D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs from Libcpp bitset syntethic children and tests to [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 26 2021, 9:04 AM · Restricted Project

Oct 25 2021

wallace accepted D112501: Add new key/value pairs to the module statistics for "statistics dump"..

looks good

Oct 25 2021, 6:48 PM · Restricted Project
wallace added a reviewer for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs: clayborg.
Oct 25 2021, 3:57 PM · Restricted Project
wallace added inline comments to D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 25 2021, 2:50 PM · Restricted Project
wallace requested changes to D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

almost there!

Oct 25 2021, 2:31 PM · Restricted Project
wallace accepted D112439: normalize file path when searching the source map.

Is it possible to add a test for that? In any case, this makes sense to me

Oct 25 2021, 10:16 AM · Restricted Project

Oct 22 2021

wallace added a comment to D112279: Add modules stats into the "statistics dump" command..

this seems like a better solution. I like it

Oct 22 2021, 7:08 PM · Restricted Project
wallace updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

nit

Oct 22 2021, 2:31 PM · Restricted Project
wallace updated the diff for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.

addressed all comments.
I was able to dedup all the implementation files and the tests, and indeed passing
the make flags to the build method was a good trick.

Oct 22 2021, 2:27 PM · Restricted Project
wallace commandeered D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs.
Oct 22 2021, 2:26 PM · Restricted Project
wallace accepted D112279: Add modules stats into the "statistics dump" command..

looks good, does anyone else have any objections?

Oct 22 2021, 2:11 PM · Restricted Project

Oct 20 2021

wallace added a reviewer for D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs: wallace.
Oct 20 2021, 2:39 PM · Restricted Project

Oct 19 2021

wallace abandoned D107407: [rfc] target stats.
Oct 19 2021, 1:02 PM · Restricted Project

Oct 13 2021

wallace added inline comments to D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided..
Oct 13 2021, 10:32 PM · Restricted Project
wallace added inline comments to D111686: Modify "statistics dump" to dump JSON..
Oct 13 2021, 10:26 PM · Restricted Project

Sep 23 2021

wallace updated subscribers of D110269: Fix LLDB build on old Linux kernels.

I will! Thanks!

Sep 23 2021, 10:26 AM · Restricted Project

Sep 22 2021

wallace accepted D110269: Fix LLDB build on old Linux kernels.

thanks!!

Sep 22 2021, 10:40 AM · Restricted Project

Sep 14 2021

wallace closed D105998: Create synthetic symbol names on demand to improve memory consumption and startup times..

This was commited by ec1a49170129d

Sep 14 2021, 12:08 AM · Restricted Project

Sep 13 2021

wallace accepted D109633: [lldb-vscode] Fix focus thread when previous thread exits.

nice!

Sep 13 2021, 1:41 PM · Restricted Project

Sep 8 2021

wallace accepted D109401: Log to the right stream in DwarfTransformer::handleDie()..

makes sense!

Sep 8 2021, 11:37 AM · Restricted Project

Aug 22 2021

wallace accepted D108497: Fix fallback code that gets decl file + line..

makes sense!

Aug 22 2021, 3:00 PM · Restricted Project

Aug 16 2021

wallace accepted D107669: [trace] [intel pt] Create a "process trace save" command.

good job

Aug 16 2021, 2:02 PM · Restricted Project

Aug 13 2021

wallace requested changes to D107669: [trace] [intel pt] Create a "process trace save" command.

Almost there. Many cosmetic changes but the logic is all good.

Aug 13 2021, 11:22 PM · Restricted Project
wallace resigned from D70885: [lldb] Use explicit lldb commands on tests.
Aug 13 2021, 11:56 AM · Restricted Project
wallace resigned from D70887: [lldb] Use realpath to avoid issues with symlinks in source paths.
Aug 13 2021, 11:55 AM · Restricted Project

Aug 11 2021

wallace requested changes to D107669: [trace] [intel pt] Create a "process trace save" command.

discussed offline of some improvements to make

Aug 11 2021, 10:22 PM · Restricted Project

Aug 9 2021

wallace added inline comments to D107669: [trace] [intel pt] Create a "process trace save" command.
Aug 9 2021, 10:12 PM · Restricted Project