[scan-build] fix dead store warnings emitted on clang code base

[apelete]

Summary

This fixes dead store warnings of the type "dead assignment" reported
by CLang Static Analyzer on the following file:

• tools/c-index-test/c-index-test.c.

Signed-off-by: Apelete Seketeli <[e-mail]>

[dblaikie]

Any reason not to remove the story instead?

[apelete]

In D19831#419140, @dblaikie wrote:

Any reason not to remove the story instead?

What do you mean by "remove the story" ?

[dblaikie]

Sorry, I meant remove the /store/, if it's dead. The do/while loop
overwrites the store immediately, so just remove the assignment to Record?

[apelete]

In D19831#419456, @dblaikie wrote:

Sorry, I meant remove the /store/, if it's dead. The do/while loop
overwrites the store immediately, so just remove the assignment to Record?

Makes sense, I overlooked that. Will fix in next revision.

[apelete]

[scan-build] fix dead store warnings emitted on clang code base

Changes since last revision:

• remove dead store since the do {} while() loop overwrite it immediatly anyway.

[dblaikie]

Looks good to me - go ahead & commit whenever you're ready.

[apelete]

tools/c-index-test/c-index-test.c

1440 ↗

(On Diff #55952)

This line now causes a new "uninitialized argument value" warning because Parent variable isn't initialized anymore and Record variable is being passed here without being initialized either consequently.

Will fix in next revision.

[apelete]

[scan-build] fix dead store warnings emitted on clang code base

Changes since last revision:

• Initialize 'CXCursor Parent' variable to avoid passing 'Record' variable as an un-initialized argument thereafter.

[apelete]

In D19831#420115, @dblaikie wrote:

Looks good to me - go ahead & commit whenever you're ready.

If this last revision is good for you, please go ahead and commit this for me (I don't have commit access).

Thanks.

[dblaikie]

tools/c-index-test/c-index-test.c

1435–1436 ↗

(On Diff #56042)

Could you move these two declarations into the if (1438) since they appear to only be used within that scope anyway?

[apelete]

[scan-build] fix dead store warnings emitted on clang code base

Changes since last revision:

• Move 'Record' and 'Parent' variables into if() {} scope where they are actually used.

[dblaikie]

Thanks - do you need someone (me) to commit this, or do you have commit
access?

[apelete]

In D19831#420410, @dblaikie wrote:

Thanks - do you need someone (me) to commit this, or do you have commit
access?

I would appreciate if you could commit this for me since I don't have commit access.
Thanks.

cfe/trunk/tools/c-index-test/c-index-test.c

if (Align >= 0 || Align < -1) {
       printf(" [alignof=%lld]", Align);
     }
   }
   /* Print the record field offset if applicable. */
   {
     CXString FieldSpelling = clang_getCursorSpelling(cursor);
     const char *FieldName = clang_getCString(FieldSpelling);
     /* recurse to get the first parent record that is not anonymous. */
-    CXCursor Parent, Record;
     unsigned RecordIsAnonymous = 0;
     if (clang_getCursorKind(cursor) == CXCursor_FieldDecl) {
-      Record = Parent = p;
+      CXCursor Record;
+      CXCursor Parent = p;
       do {
         Record = Parent;
         Parent = clang_getCursorSemanticParent(Record);
         RecordIsAnonymous = clang_Cursor_isAnonymous(Record);
         /* Recurse as long as the parent is a CXType_Record and the Record
            is anonymous */
       } while ( clang_getCursorType(Parent).kind == CXType_Record &&
                 RecordIsAnonymous > 0);