This is an archive of the discontinued LLVM Phabricator instance.

[AVX512] lowerV4X128VectorShuffle doesn't correctly select input operands .
ClosedPublic

Authored by igorb on May 2 2016, 6:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 55809.May 2 2016, 6:12 AM
igorb retitled this revision from to [AVX512] lowerV4X128VectorShuffle doesn't correctly select input operands ..
igorb updated this object.
igorb added reviewers: delena, RKSimon.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: llvm-commits.
RKSimon added inline comments.May 2 2016, 6:35 AM
lib/Target/X86/X86ISelLowering.cpp
11562

Why not just set the Ops[] element to UNDEF?

test/CodeGen/X86/vector-shuffle-512-v8.ll
2283

Typically we just use a single 'u' to indicate that the shuffle mask element is undefined. In this case the test would be called: shuffle_v8f64_2301uu67. Similar for the other tests.

igorb updated this revision to Diff 55817.May 2 2016, 7:42 AM
igorb marked 2 inline comments as done.

Changed according to comments,
Thanks!

RKSimon accepted this revision.May 2 2016, 9:28 AM
RKSimon edited edge metadata.

LGTM

test/CodeGen/X86/vector-shuffle-512-v8.ll
2299

Shouldn't this be shuffle_v8f64_uuuu2301 ?

This revision is now accepted and ready to land.May 2 2016, 9:28 AM
This revision was automatically updated to reflect the committed changes.
igorb marked an inline comment as done.May 3 2016, 1:17 AM

Thanks for review!