AMDGPU: Add support for MCExpr to instruction printer

[jvesely]

Summary

global addresses are such expressions

[arsenm]

Needs a test

lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp

608–609 ↗

(On Diff #55779)

Why change this? It's already being truncated. Maybe add an explicit static_cast to the Imm assignment?

612 ↗

(On Diff #55779)

Single quotes

[jvesely]

Use single quotes

lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp

608–609 ↗

(On Diff #55779)

Since there should be only 32 bit values, the idea was to print all 64 bits and catch any bugs/corruption in asm output.

[jvesely]

In D19790#418905, @arsenm wrote:

Needs a test

I extended tests in D19792 to cover this

[• tstellarAMD]

LGTM.

[arsenm]

lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp

608–609 ↗

(On Diff #55949)

That's not happening anyway, because there is the implicit cast in the BitsToFloat call

llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.h

private:
   static void printInterpSlot(const MCInst *MI, unsigned OpNum, raw_ostream &O);
   void printMemOperand(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printIfSet(const MCInst *MI, unsigned OpNo, raw_ostream &O,
                          StringRef Asm, StringRef Default = "");
   static void printAbs(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printClamp(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printClampSI(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printOModSI(const MCInst *MI, unsigned OpNo, raw_ostream &O);
-  static void printLiteral(const MCInst *MI, unsigned OpNo, raw_ostream &O);
+  void printLiteral(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printLast(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printNeg(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printOMOD(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printRel(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printUpdateExecMask(const MCInst *MI, unsigned OpNo,
                                   raw_ostream &O);
   static void printUpdatePred(const MCInst *MI, unsigned OpNo, raw_ostream &O);
   static void printWrite(const MCInst *MI, unsigned OpNo, raw_ostream &O);

llvm/trunk/lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp

void AMDGPUInstPrinter::printOModSI(const MCInst *MI, unsigned OpNo,
   else if (Imm == SIOutMods::MUL4)
     O << " mul:4";
   else if (Imm == SIOutMods::DIV2)
     O << " div:2";
 }
 
 void AMDGPUInstPrinter::printLiteral(const MCInst *MI, unsigned OpNo,
                                      raw_ostream &O) {
-  int32_t Imm = MI->getOperand(OpNo).getImm();
+  const MCOperand &Op = MI->getOperand(OpNo);
+  assert(Op.isImm() || Op.isExpr());
+  if (Op.isImm()) {
+    int64_t Imm = Op.getImm();
     O << Imm << '(' << BitsToFloat(Imm) << ')';
   }
+  if (Op.isExpr()) {
+    Op.getExpr()->print(O << '@', &MAI);
+  }
+}
 
 void AMDGPUInstPrinter::printLast(const MCInst *MI, unsigned OpNo,
                                   raw_ostream &O) {
   printIfSet(MI, OpNo, O, "*", " ");
 }
 
 void AMDGPUInstPrinter::printNeg(const MCInst *MI, unsigned OpNo,
                                  raw_ostream &O) {