Prepare LLDB Windows builder to be able to run tests

[zturner]

Summary

In a followup patch I want to flip the test flag to True, but I want to do this in preparation first since it is a necessary first step, and if testing doesn't work out and we have to turn them back off, this is still a good change that should stay.

[gkistanova]

LGTM with the minor issue.

Thanks

Galina

zorg/buildbot/builders/LLDBBuilder.py

96 ↗

(On Diff #55433)

This will use the path separator specific to the buildmaster. Should work for you now, but could introduce issues if we would move buildmaster to, let's say, Windows.

Maybe just hard code the path separator to keep it consistent to the rest of the module?

zorg/trunk/buildbot/osuosl/master/config/builders.py

return [
        ]
 
 # LLDB builders.
 def _get_lldb_builders():
     return [
         {'name': "lldb-x86-windows-msvc2015",
          'slavenames': ["zturner-win2008"],
          'builddir': "lldb-windows-x86",
-         'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory(config='Debug')},
+         'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory()},
         {'name': "lldb-x86-win7-msvc",
          'slavenames': ["hexagon-build-01"],
          'builddir': "builddir/lldb-win7-msvc",
          'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory(config='Debug')},
         {'name': "lldb-x86_64-ubuntu-14.04-buildserver",
          'slavenames': ["lldb-linux-android-buildserver"],
          'builddir': "lldb-android-buildserver",
          'category' : 'lldb',

zorg/trunk/zorg/buildbot/builders/LLDBBuilder.py

f.addStep(RemoveDirectory(name='clean '+build_dir,
                 dir=build_dir,
                 haltOnFailure=False,
                 flunkOnFailure=False,
                 doStepIf=cleanBuildRequested
                 ))
 
     # Use batch files instead of ShellCommand directly, Windows quoting is
     # borked. FIXME: See buildbot ticket #595 and buildbot ticket #377.
+    clang_exe = 'build_dir/bin/clang.exe'    # ./bin/clang.exe
     f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
                                 command=[cmake, "-G", "Ninja", "../llvm",
                                          "-DCMAKE_BUILD_TYPE="+config,
                                          '-DPYTHON_HOME=' + python_source_dir,
-                                         "-DCMAKE_INSTALL_PREFIX=../install"]
+                                         "-DCMAKE_INSTALL_PREFIX=../install",
+                                         "-DLLDB_TEST_COMPILER=" + clang_exe]
                                          + extra_cmake_args,
                                 workdir=build_dir))
 
     f.addStep(ShellCommand(name='cmake',
                            command=['cmakegen.bat'],
                            haltOnFailure=True,
                            description='cmake gen',
                            workdir=build_dir,