This is an archive of the discontinued LLVM Phabricator instance.

Fix test on Windows
ClosedPublic

Authored by vitalybuka on Apr 22 2016, 12:00 PM.

Diff Detail

Event Timeline

vitalybuka retitled this revision from to Fix test on Windows.
vitalybuka updated this object.
vitalybuka added a subscriber: llvm-commits.
eugenis edited edge metadata.Apr 22 2016, 2:01 PM

What does the entire stack look like?
Is it because of -O1? Can you get rid of it?

vitalybuka updated this revision to Diff 54729.Apr 22 2016, 2:44 PM
vitalybuka edited edge metadata.

Fixed expectation to only check operator()

When I run check-asan I have:

#0 0x1241f83 in main ..\llvm\projects\compiler-rt\test\asan\TestCases\use-after-scope-capture.cc:12:14
#1 0x1241f1e in main C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\type_traits:1398:11
#2 0x1241eee in main C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\type_traits:1466:10
#3 0x1241ece in main C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\type_traits:1491:10
#4 0x12418ae in main C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\functional:212:11

When I run the same temp binary generated by the test run above I see:

#0 0x3d1f83 in main()::(anonymous class)::operator() ..\llvm\projects\compiler-rt\test\asan\TestCases\

use-after-scope-capture.cc:12

#1 0x3d1f1e in std::_Invoker_functor::_Call C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\type_trai

ts:1398

#2 0x3d1eee in std::invoke C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\type_traits:1466
#3 0x3d1ece in std::_Invoke_ret C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\type_traits:1491

So this looks like symbols interpreted differently.

vitalybuka updated this revision to Diff 54751.Apr 22 2016, 5:11 PM

Update expression.

eugenis accepted this revision.Apr 22 2016, 5:12 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 22 2016, 5:12 PM
vitalybuka abandoned this revision.Apr 27 2016, 2:51 PM

llvm-symbolizer is fixed and the test is re-enabled with r267735

vitalybuka reclaimed this revision.May 2 2016, 12:18 PM
This revision is now accepted and ready to land.May 2 2016, 12:18 PM
vitalybuka updated this revision to Diff 55913.May 2 2016, 4:36 PM
vitalybuka edited edge metadata.

Update description.

This revision was automatically updated to reflect the committed changes.