This is an archive of the discontinued LLVM Phabricator instance.

[ValueTracking] Make isImpliedCondition return an Optional<bool>. NFC.
ClosedPublic

Authored by mcrosier on Apr 19 2016, 11:50 AM.

Details

Summary

This is follow up from D18905. Thanks, Chad.

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 54235.Apr 19 2016, 11:50 AM
mcrosier retitled this revision from to [ValueTracking] Make isImpliedCondition return an Optional<bool>. NFC..
mcrosier updated this object.
mcrosier added a reviewer: reames.
mcrosier added a subscriber: llvm-commits.
junbuml added inline comments.Apr 20 2016, 9:07 AM
lib/Analysis/ValueTracking.cpp
3793–3795

Please update the comment.

mcrosier updated this revision to Diff 54383.Apr 20 2016, 9:30 AM

Address Jun's feedback.

mcrosier marked an inline comment as done.Apr 20 2016, 9:30 AM
sanjoy accepted this revision.Apr 20 2016, 10:56 AM
sanjoy edited edge metadata.

lgtm

(Didn't look too closely, since this is a straightforward refactoring change)

This revision is now accepted and ready to land.Apr 20 2016, 10:56 AM
mcrosier closed this revision.Apr 20 2016, 12:22 PM

Thanks, Sanjoy. Committed r266904.