This is an archive of the discontinued LLVM Phabricator instance.

Remove some unneeded headers and replace some headers with forward class declarations
ClosedPublic

Authored by kevgs on Apr 15 2016, 3:16 AM.

Diff Detail

Event Timeline

kevgs updated this revision to Diff 53867.Apr 15 2016, 3:16 AM
kevgs retitled this revision from to Remove some unneeded headers and replace some headers with forward class declarations .
kevgs updated this object.
kevgs added reviewers: chandlerc, craig.topper.
kevgs added a subscriber: llvm-commits.
kevgs added a comment.Apr 15 2016, 3:28 AM

After applying this patch clang file include/clang/Lex/LiteralSupport.h needs to be added a "llvm/ADT/ArrayRef.h" header to it to fix a broken build.

LGTM, Thanks.

include/llvm/ADT/APFloat.h
29

You can still include APFloat without including SmallVector right?

Thanks for your review. I have no commit rights.

include/llvm/ADT/APFloat.h
29

Yes, unless you're using SmallVector in your code.

mehdi_amini accepted this revision.Apr 15 2016, 1:27 PM
mehdi_amini added a reviewer: mehdi_amini.
This revision is now accepted and ready to land.Apr 15 2016, 1:27 PM
mehdi_amini closed this revision.Apr 16 2016, 12:59 AM

Thanks! r266524