Page MenuHomePhabricator

Fix breakpoint_set_restart test for Windows
ClosedPublic

Authored by amccarth on Apr 12 2016, 3:18 PM.

Details

Summary

When run with the multiprocess test runner, the getchar() trick doesn't work, so ninja check-lldb would fail on this test, but running the test directly worked fine.

This replaces the getchar() call with an infinite loop.

Thanks to Pavel for the insight.

Diff Detail

Event Timeline

amccarth updated this revision to Diff 53472.Apr 12 2016, 3:18 PM
amccarth retitled this revision from to Fix breakpoint_set_restart test for Windows.
amccarth updated this object.
amccarth added reviewers: ovyalov, labath.
amccarth added a subscriber: lldb-commits.
ovyalov accepted this revision.Apr 12 2016, 3:32 PM
ovyalov edited edge metadata.
ovyalov added inline comments.
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp
11

You may remove iostream since getchar is no longer needed.

This revision is now accepted and ready to land.Apr 12 2016, 3:32 PM
amccarth marked an inline comment as done.Apr 12 2016, 3:44 PM
amccarth added inline comments.
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp
11

Done since getchar actually comes from stdio.h anyway.

This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.