This is an archive of the discontinued LLVM Phabricator instance.

Move summary creation out of llvm-as into opt
ClosedPublic

Authored by mehdi_amini on Apr 12 2016, 1:40 PM.

Details

Summary

Let keep llvm-as "dumb": it converts textual IR to bitcode.
We'll add back summary in llvm-as if we get to a textual
representation for it at some point. In the meantime, opt seems
like a better place for that.

Diff Detail

Event Timeline

mehdi_amini retitled this revision from to Move summary creation out of llvm-as into opt.
mehdi_amini updated this object.
mehdi_amini added a reviewer: tejohnson.
mehdi_amini added a subscriber: llvm-commits.

Update CMakelist.txt and LLVMBUILD.txt to remove the dependency from llvm-as to libLLVMAnalysis

Update gold plugin test (note I didn't run any test, this is blind update)

tejohnson accepted this revision.Apr 12 2016, 1:56 PM
tejohnson edited edge metadata.

One fix needed (looks like an unintended change noted below)?

Let me know if you want me to run the gold tests before submitting, but I think it looks pretty straightforward.

include/llvm/ExecutionEngine/ExecutionEngine.h
568

Inadvertent change?

This revision is now accepted and ready to land.Apr 12 2016, 1:56 PM
tejohnson added inline comments.Apr 13 2016, 7:47 AM
include/llvm/ExecutionEngine/ExecutionEngine.h
568

Looks like this change wasn't removed before submit in r266131.

mehdi_amini closed this revision.Apr 13 2016, 11:58 AM
mehdi_amini marked an inline comment as done.

r266131

include/llvm/ExecutionEngine/ExecutionEngine.h
568

Yes!

568

sorry, fixed in r266210