This is an archive of the discontinued LLVM Phabricator instance.

Refactor the Internalize stage of libLTO in a separate file (NFC)
ClosedPublic

Authored by mehdi_amini on Apr 11 2016, 6:21 PM.

Details

Summary

This is intended to be shared by the ThinLTOCodeGenerator.

Note that there is a change in the way the verifier is run, previously
it was ran as a Pass on the merged module during internalization.
While now the verifier is called explicitely on the merged module
outside of the internalize "pass pipeline".

What is strange in the API is the fact that DisableVerify in the API
does not disable this initial verifier.

Diff Detail

Event Timeline

mehdi_amini retitled this revision from to Refactor the Internalize stage of libLTO in a separate file (NFC).
mehdi_amini updated this object.
mehdi_amini added a reviewer: dexonsmith.
mehdi_amini added a subscriber: llvm-commits.

Update test

Typo (member StringSet was supposed to be a reference)

Const correctness

Remove unintended added file

davide accepted this revision.Apr 11 2016, 11:15 PM
davide added a reviewer: davide.
davide added a subscriber: davide.

This sounds reasonable to me.

This revision is now accepted and ready to land.Apr 11 2016, 11:15 PM
mehdi_amini closed this revision.Apr 11 2016, 11:39 PM

Thanks r266046