This is an archive of the discontinued LLVM Phabricator instance.

note for top-level consts in function decls tidy
ClosedPublic

Authored by fowles on Mar 30 2016, 10:00 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

fowles updated this revision to Diff 52083.Mar 30 2016, 10:00 AM
fowles retitled this revision from to note for top-level consts in function decls tidy.
fowles updated this object.
fowles added a reviewer: alexfh.
fowles added a subscriber: cfe-commits.
LegalizeAdulthood added inline comments.
docs/ReleaseNotes.rst
153–154 ↗(On Diff #52083)

Was this added in 3.8 or is it being added in 3.9?

That URL gives me 404 not found.

If it is new to 3.9, it should be farther up in the file.

fowles added inline comments.Mar 30 2016, 2:20 PM
docs/ReleaseNotes.rst
153–154 ↗(On Diff #52083)

I don't know. It was committed yesterday.

docs/ReleaseNotes.rst
153–154 ↗(On Diff #52083)

Hrm. I see the page describing it here:
http://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html
but I think those docs are continuously rebuilt from trunk.

The release specific URL you added does not work and if you look in the base directory for that URL:
http://llvm.org/releases/3.8.0/tools/clang/tools/extra/docs/clang-tidy/checks/
you will not find a file for readability-avoid-const-params-in-decls

I suspect it means that the documentation was added since the 3.8 release and therefore the check isn't actually available in the 3.8 release either. Yep, looking at the github mirror for branch release_38, this check isn't present. See the mirror on github to verify this.

Therefore, I conclude that the check should be listed in the what's new for 3.9 section and not what was added between 3.7 and 3.8.

fowles updated this revision to Diff 52126.Mar 30 2016, 2:36 PM
  • move release note to 3.9 section
fowles marked an inline comment as done.Mar 30 2016, 2:36 PM
This revision was automatically updated to reflect the committed changes.
alexfh added inline comments.Mar 31 2016, 5:12 AM
docs/ReleaseNotes.rst
73 ↗(On Diff #52126)

Typo: "delcartions". Fixed in a follow up.

alexfh edited edge metadata.Mar 31 2016, 5:13 AM

Thank you for the patch, btw!