User Details
User Details
- User Since
- Mar 7 2016, 8:28 AM (253 w, 6 d)
Apr 19 2020
Apr 19 2020
fowles added a comment to D78323: [clang] Fix invalid comparator in tablegen.
LGTM
Apr 19 2020, 9:37 AM · Restricted Project
Apr 15 2020
Apr 15 2020
Apr 15 2020, 12:36 PM · Restricted Project
Dec 10 2018
Dec 10 2018
fowles added inline comments to D55534: [AST] Store "UsesADL" information in CallExpr..
May 30 2017
May 30 2017
fowles updated the diff for D33679: Make clang-query close parens for you.
Add tests for real
fowles updated the diff for D33679: Make clang-query close parens for you.
Add a test
Switching to https://reviews.llvm.org/D33679 for sbenza's suggestion
May 27 2017
May 27 2017
Jan 10 2017
Jan 10 2017
fowles updated subscribers of D28260: Add an argumentsAre matcher.
@jdennett wanted this matcher for something he is working on and I had some free cycles to write it up. Unfortunately, I am about to leave on an extended vacation, so I will not be able to follow up with this patch for 2 months at the earliest.
Jan 3 2017
Jan 3 2017
Aug 10 2016
Aug 10 2016
fowles added inline comments to D23353: [clang-tidy] Add check 'misc-use-after-move'.
May 24 2016
May 24 2016
fowles added a comment to D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified .
LGTM, but I will wait for people who know this stuff better to sign off
Apr 11 2016
Apr 11 2016
fowles accepted D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its.
Thanks for doing this! I tried a bunch of variants and just couldn't figure it out.
Mar 30 2016
Mar 30 2016
fowles added a comment to D18608: note for top-level consts in function decls tidy.
fowles updated the diff for D18608: note for top-level consts in function decls tidy.
- move release note to 3.9 section
fowles added inline comments to D18608: note for top-level consts in function decls tidy.
fowles added a comment to D18408: readability check for const params in declarations.
Helped by sbenza@ http://reviews.llvm.org/D18608
fowles retitled D18608: note for top-level consts in function decls tidy from to note for top-level consts in function decls tidy.
fowles added a comment to D18408: readability check for const params in declarations.
that is what I was trying to do. I can't seem to make arc play nice.
fowles added a comment to D18408: readability check for const params in declarations.
My attempts to do this end with:
Mar 29 2016
Mar 29 2016
fowles updated the diff for D18408: readability check for const params in declarations.
- review comments
- rename variables and remove MSVC compat issues
fowles added a comment to D18408: readability check for const params in declarations.
ping?
Mar 24 2016
Mar 24 2016
fowles updated the diff for D18408: readability check for const params in declarations.
- review comments
Mar 23 2016
Mar 23 2016
fowles retitled D18408: readability check for const params in declarations from to readability check for const params in declarations.
fowles added a comment to D18149: Add check for unneeded copies of locals.
thank you!
Mar 22 2016
Mar 22 2016
fowles added inline comments to D18149: Add check for unneeded copies of locals.
fowles updated the diff for D18149: Add check for unneeded copies of locals.
rebased to latest. Can someone submit this for me I don't have commit bits.
Mar 21 2016
Mar 21 2016
fowles updated the diff for D18149: Add check for unneeded copies of locals.
Mar 17 2016
Mar 17 2016
fowles updated the diff for D18149: Add check for unneeded copies of locals.
Mar 16 2016
Mar 16 2016
fowles updated the diff for D18149: Add check for unneeded copies of locals.
fowles updated the diff for D18149: Add check for unneeded copies of locals.
fowles added a comment to D18149: Add check for unneeded copies of locals.
Mar 14 2016
Mar 14 2016
fowles retitled D18149: Add check for unneeded copies of locals from to Add check for unneeded copies of locals.