Page MenuHomePhabricator

fowles (Matt Kulukundis)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2016, 8:28 AM (253 w, 6 d)

Recent Activity

Apr 19 2020

fowles accepted rGaf2968e37f4c: [clang] Fix invalid comparator in tablegen.
Apr 19 2020, 9:37 AM
fowles added a comment to D78323: [clang] Fix invalid comparator in tablegen.

LGTM

Apr 19 2020, 9:37 AM · Restricted Project

Apr 15 2020

fowles accepted D78223: [clang-tidy] performance-range-for-copy only for copy..
Apr 15 2020, 12:36 PM · Restricted Project

Dec 10 2018

fowles added inline comments to D55534: [AST] Store "UsesADL" information in CallExpr..
Dec 10 2018, 9:59 PM

May 30 2017

fowles updated the diff for D33679: Make clang-query close parens for you.

Add tests for real

May 30 2017, 8:34 AM
fowles updated the diff for D33679: Make clang-query close parens for you.

Add a test

May 30 2017, 8:34 AM
fowles abandoned D33623: Make the parser close parens for you on EOF.

Switching to https://reviews.llvm.org/D33679 for sbenza's suggestion

May 30 2017, 8:30 AM
fowles created D33679: Make clang-query close parens for you.
May 30 2017, 8:29 AM

May 27 2017

fowles created D33623: Make the parser close parens for you on EOF.
May 27 2017, 12:20 PM

Jan 10 2017

fowles updated subscribers of D28260: Add an argumentsAre matcher.

@jdennett wanted this matcher for something he is working on and I had some free cycles to write it up. Unfortunately, I am about to leave on an extended vacation, so I will not be able to follow up with this patch for 2 months at the earliest.

Jan 10 2017, 12:50 PM

Jan 3 2017

fowles retitled D28260: Add an argumentsAre matcher from to Add an argumentsAre matcher.
Jan 3 2017, 3:36 PM
fowles abandoned D28259: Add an argumentsAre matcher.
Jan 3 2017, 3:32 PM
fowles retitled D28259: Add an argumentsAre matcher from to Add an argumentsAre matcher.
Jan 3 2017, 3:13 PM

Aug 10 2016

fowles added inline comments to D23353: [clang-tidy] Add check 'misc-use-after-move'.
Aug 10 2016, 9:09 AM

May 24 2016

fowles added a comment to D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified .

LGTM, but I will wait for people who know this stuff better to sign off

May 24 2016, 6:48 AM

Apr 11 2016

fowles accepted D18993: [clang-tidy] fix readability-avoid-const-params-in-decls creating invalid code in fix-its.

Thanks for doing this! I tried a bunch of variants and just couldn't figure it out.

Apr 11 2016, 2:50 PM

Mar 30 2016

fowles added a comment to D18608: note for top-level consts in function decls tidy.
Mar 30 2016, 2:36 PM
fowles updated the diff for D18608: note for top-level consts in function decls tidy.
  • move release note to 3.9 section
Mar 30 2016, 2:36 PM
fowles added inline comments to D18608: note for top-level consts in function decls tidy.
Mar 30 2016, 2:20 PM
fowles added a comment to D18408: readability check for const params in declarations.

Helped by sbenza@ http://reviews.llvm.org/D18608

Mar 30 2016, 10:01 AM
fowles retitled D18608: note for top-level consts in function decls tidy from to note for top-level consts in function decls tidy.
Mar 30 2016, 10:00 AM
fowles added a comment to D18408: readability check for const params in declarations.

that is what I was trying to do. I can't seem to make arc play nice.

Mar 30 2016, 9:49 AM
fowles added a comment to D18408: readability check for const params in declarations.

My attempts to do this end with:

Mar 30 2016, 7:01 AM

Mar 29 2016

fowles updated the diff for D18408: readability check for const params in declarations.
  • review comments
  • rename variables and remove MSVC compat issues
Mar 29 2016, 10:54 AM
fowles added a comment to D18408: readability check for const params in declarations.

ping?

Mar 29 2016, 8:48 AM

Mar 24 2016

fowles updated the diff for D18408: readability check for const params in declarations.
  • review comments
Mar 24 2016, 1:32 PM

Mar 23 2016

fowles retitled D18408: readability check for const params in declarations from to readability check for const params in declarations.
Mar 23 2016, 10:57 AM
fowles added a comment to D18149: Add check for unneeded copies of locals.

thank you!

Mar 23 2016, 7:01 AM

Mar 22 2016

fowles added inline comments to D17491: Add performance check to flag function parameters of expensive to copy types that can be safely converted to const references..
Mar 22 2016, 8:43 AM
fowles added inline comments to D18149: Add check for unneeded copies of locals.
Mar 22 2016, 8:02 AM
fowles updated the diff for D18149: Add check for unneeded copies of locals.

rebased to latest. Can someone submit this for me I don't have commit bits.

Mar 22 2016, 8:01 AM

Mar 21 2016

fowles updated the diff for D18149: Add check for unneeded copies of locals.
Mar 21 2016, 12:45 PM

Mar 17 2016

fowles updated the diff for D18149: Add check for unneeded copies of locals.
Mar 17 2016, 6:49 AM

Mar 16 2016

fowles updated the diff for D18149: Add check for unneeded copies of locals.
Mar 16 2016, 2:59 PM
fowles updated the diff for D18149: Add check for unneeded copies of locals.
Mar 16 2016, 2:53 PM
fowles added a comment to D18149: Add check for unneeded copies of locals.
Mar 16 2016, 2:51 PM

Mar 14 2016

fowles added reviewers for D18149: Add check for unneeded copies of locals: alexfh, hokein.
Mar 14 2016, 9:01 AM
fowles retitled D18149: Add check for unneeded copies of locals from to Add check for unneeded copies of locals.
Mar 14 2016, 8:45 AM