llvm-mc: AsmParser: handle '\v' as an escaped character

[thegameg]

Summary

• lib/MC/MCAsmStreamer.cpp: Print '\v' as the escaped sequence.
• lib/MC/MCParser/AsmParser.cpp: Add '\v' to the escaped characters list.
• test/MC/AsmParser/directive_ascii.s: Update escaped characters test.

[• rafael]

Is this a gas feature. It is not listed in
https://sourceware.org/binutils/docs/as/Strings.html#Strings.

Cheers,
Rafael

[thegameg]

In D18587#390651, @rafael wrote:

Is this a gas feature. It is not listed in
https://sourceware.org/binutils/docs/as/Strings.html#Strings.

Indeed, my bad. I just noticed that none of those extensions are implemented.
I'll drop the patch.

Thanks,
Francis

lib/MC/MCAsmStreamer.cpp

for (unsigned i = 0, e = Data.size(); i != e; ++i) {
     }
 
     switch (C) {
       case '\b': OS << "\\b"; break;
       case '\f': OS << "\\f"; break;
       case '\n': OS << "\\n"; break;
       case '\r': OS << "\\r"; break;
       case '\t': OS << "\\t"; break;
+      case '\v': OS << "\\v"; break;
       default:
         OS << '\\';
         OS << toOctal(C >> 6);
         OS << toOctal(C >> 3);
         OS << toOctal(C >> 0);
         break;
     }
   }

lib/MC/MCParser/AsmParser.cpp

default:
       // Just reject invalid escape sequences for now.
       return TokError("invalid escape sequence (unrecognized character)");
 
     case 'b': Data += '\b'; break;
     case 'f': Data += '\f'; break;
     case 'n': Data += '\n'; break;
     case 'r': Data += '\r'; break;
     case 't': Data += '\t'; break;
+    case 'v': Data += '\v'; break;
     case '"': Data += '"'; break;
     case '\\': Data += '\\'; break;
     }
   }
 
   return false;
 }
 

test/MC/AsmParser/directive_ascii.s

TEST3:
         .asciz "B", "C"
         
 # CHECK: TEST4:
 # CHECK: .asciz "\001\001\007\0008\001\0001\200"
 TEST4:  
         .ascii "\1\01\07\08\001\0001\200\0"
         
 # CHECK: TEST5:
-# CHECK: .ascii "\b\f\n\r\t\\\""
+# CHECK: .ascii "\b\f\n\r\t\v\\\""
 TEST5:
-        .ascii "\b\f\n\r\t\\\""
+        .ascii "\b\f\n\r\t\v\\\""
         
 # CHECK: TEST6:
 # CHECK: .byte 66
 # CHECK: .byte 0
 # CHECK: .byte 67
 # CHECK: .byte 0
 TEST6:
         .string "B", "C"