This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add a shader calling convention
ClosedPublic

Authored by bnieuwenhuizen on Mar 29 2016, 9:26 AM.

Details

Summary

This makes it possible to distinguish between mesa shaders
and other kernels even in the presence of compute shaders.

This patch depends in its current form on D18292, but only because
it also updates the newly added testcases to use the new
calling convention.

Signed-off-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

Diff Detail

Repository
rL LLVM

Event Timeline

bnieuwenhuizen retitled this revision from to AMDGPU: Add a shader calling convention.
bnieuwenhuizen updated this object.
bnieuwenhuizen added a subscriber: llvm-commits.
arsenm added inline comments.Mar 29 2016, 9:38 AM
include/llvm/IR/CallingConv.h
181–182 ↗(On Diff #51934)

I was actually thinking of having one for each kind of shader

One calling convention per shader kind it is then.

TCS/TES (or hardware HS/LS/ES etc.) are not added yet, because they
currently work the same as VS.

tstellarAMD accepted this revision.Apr 1 2016, 1:38 PM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Apr 1 2016, 1:38 PM
This revision was automatically updated to reflect the committed changes.