This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Add MachineBasicBlock parameter to SIInstrInfo::insertWaitStates
ClosedPublic

Authored by tstellarAMD on Mar 29 2016, 7:11 AM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Add MachineBasicBlock parameter to SIInstrInfo::insertWaitStates.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Mar 29 2016, 9:14 AM
arsenm edited edge metadata.

LGTM. Is this ever actually different than MI->getParent()?

This revision is now accepted and ready to land.Mar 29 2016, 9:14 AM

LGTM. Is this ever actually different than MI->getParent()?

MI is an iterator, so it could be BasicBlock::end(), which isn't always an instruction and doesn't have a parent.

This revision was automatically updated to reflect the committed changes.