This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Fix broken test with redundant string init (msvc).
ClosedPublic

Authored by etienneb on Mar 22 2016, 11:21 AM.

Download Raw Diff

Details

Reviewers

alexfh
rnk

Commits

rGe409e688a328: [clang-tidy] Fix broken test with redundant string init (msvc).
rCTE264080: [clang-tidy] Fix broken test with redundant string init (msvc).
rL264080: [clang-tidy] Fix broken test with redundant string init (msvc).

Summary

There is a silly bug that got introduced after fixing incorrect paths with this patch:
http://reviews.llvm.org/D18293

The tests was present twice in the file.

Diff Detail

Event Timeline

etienneb updated this revision to Diff 51310.Mar 22 2016, 11:21 AM

etienneb retitled this revision from to [clang-tidy] Fix broken test with redundant string init (msvc)..

etienneb updated this object.

etienneb added reviewers: rnk, alexfh.

etienneb added a subscriber: cfe-commits.

lgtm

This revision is now accepted and ready to land.Mar 22 2016, 11:22 AM

etienneb closed this revision.Mar 22 2016, 11:26 AM

Revision Contents

Path

Size

test/

clang-tidy/

readability-redundant-string-init-msvc.cpp

61 lines

Diff 51310

test/clang-tidy/readability-redundant-string-init-msvc.cpp

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines	void g() {
// CHECK-FIXES: std::wstring d;		// CHECK-FIXES: std::wstring d;

std::wstring u = L"u";		std::wstring u = L"u";
std::wstring w(L"w");		std::wstring w(L"w");
std::wstring x = LR"(x)";		std::wstring x = LR"(x)";
std::wstring y(LR"(y)");		std::wstring y(LR"(y)");
std::wstring z;		std::wstring z;
}		}
// RUN: %check_clang_tidy %s readability-redundant-string-init %t

namespace std {
template <typename T>
class allocator {};
template <typename T>
class char_traits {};
template <typename C, typename T = std::char_traits<C>, typename A = std::allocator<C>>
struct basic_string {
basic_string();
basic_string(const basic_string&);
// MSVC headers define two constructors instead of using optional arguments.
basic_string(const C *);
basic_string(const C *, const A &);
~basic_string();
};
typedef basic_string<char> string;
typedef basic_string<wchar_t> wstring;
}

void f() {
std::string a = "";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization [readability-redundant-string-init]
// CHECK-FIXES: std::string a;
std::string b("");
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string b;
std::string c = R"()";
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string c;
std::string d(R"()");
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: redundant string initialization
// CHECK-FIXES: std::string d;

std::string u = "u";
std::string w("w");
std::string x = R"(x)";
std::string y(R"(y)");
std::string z;
}

void g() {
std::wstring a = L"";
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring a;
std::wstring b(L"");
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring b;
std::wstring c = LR"()";
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring c;
std::wstring d(LR"()");
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: redundant string initialization
// CHECK-FIXES: std::wstring d;

std::wstring u = L"u";
std::wstring w(L"w");
std::wstring x = LR"(x)";
std::wstring y(LR"(y)");
std::wstring z;
}