Add GUID/getGlobalIdentifier() non-static API to global value

[mehdi_amini]

Summary

These are just helpers calling their static counter part to
simplify client code.

[mehdi_amini]

clang-format

[tejohnson]

include/llvm/IR/GlobalValue.h

319

doxygen comments on new methods

[mehdi_amini]

Add doxygen.

[mehdi_amini]

r264382

include/llvm/IR/GlobalValue.h

public:
   /// Return the modified name for a global value suitable to be
   /// used as the key for a global lookup (e.g. profile or ThinLTO).
   /// The value's original name is \c Name and has linkage of type
   /// \c Linkage. The value is defined in module \c FileName.
   static std::string getGlobalIdentifier(StringRef Name,
                                          GlobalValue::LinkageTypes Linkage,
                                          StringRef FileName);
 
+  /// Return the modified name for this global value suitable to be
+  /// used as the key for a global lookup (e.g. profile or ThinLTO).
+  std::string getGlobalIdentifier();
+
   /// Return a 64-bit global unique ID constructed from global value name
-  /// (i.e. returned by getGlobalIdentifier).
+  /// (i.e. returned by getGlobalIdentifier()).
   static uint64_t getGUID(StringRef GlobalName) { return MD5Hash(GlobalName); }
 
+  /// Return a 64-bit global unique ID constructed from global value name
+  /// (i.e. returned by getGlobalIdentifier()).
+  uint64_t getGUID() { return getGUID(getGlobalIdentifier()); }
+
   /// @name Materialization
   /// Materialization is used to construct functions only as they're needed.
   /// This
   /// is useful to reduce memory usage in LLVM or parsing work done by the
   /// BitcodeReader to load the Module.
   /// @{
 
   /// If this function's Module is being lazily streamed in functions from disk

lib/IR/Globals.cpp

if (llvm::GlobalValue::isLocalLinkage(Linkage)) {
     if (FileName.empty())
       NewName = NewName.insert(0, "<unknown>:");
     else
       NewName = NewName.insert(0, FileName.str() + ":");
   }
   return NewName;
 }
 
+std::string GlobalValue::getGlobalIdentifier() {
+  return getGlobalIdentifier(getName(), getLinkage(),
+                             getParent()->getSourceFileName());
+}
+
 const char *GlobalValue::getSection() const {
   if (auto *GA = dyn_cast<GlobalAlias>(this)) {
     // In general we cannot compute this at the IR level, but we try.
     if (const GlobalObject *GO = GA->getBaseObject())
       return GO->getSection();
     return "";
   }
   return cast<GlobalObject>(this)->getSection();