[LLDB]{MIPS] Fix TestPlatformProcessConnect.py

[nitesh.jain]

Summary

The patch http://reviews.llvm.org/D14952 which modifies the platform connect with automatically connecting to the process instance if it was started by the remote platform. However this fails for Linux Platform. Since PlatformRemoteGDBServer doesn't implement "ConnectToWaitingProcesses". Thus Platform::ConnectToWaitingProcesses was called and LLDB failed connecting to the remote process instance. This Patch implements "ConnectToWaitingProcesses" for PlatformRemoteGDBServer and hence fixes TestPlatformProcessConnect.py failure for linux Platform.

[labath]

If I understand correctly, you have simply copied the implementation from PlatformRemoteAndroidGDBServer. Could you also remove it from that class, since it's going to inherit the implementation anyway?

Apart from that, it looks good to me, but let's give a chance for @clayborg to respond first.

[clayborg]

Looks good.

[nitesh.jain]

Updated diff as per suggestion.

[labath]

Looks great. Thank you.

[nitesh.jain]

Hi Tamas Berghammer,

Is it ok to commit?

lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h

public:
 
     lldb::ProcessSP
     ConnectProcess (const char* connect_url,
                     const char* plugin_name,
                     lldb_private::Debugger &debugger,
                     lldb_private::Target *target,
                     lldb_private::Error &error) override;
 
-    size_t
-    ConnectToWaitingProcesses(lldb_private::Debugger& debugger, lldb_private::Error& error) override;
-
 protected:
     std::string m_device_id;
     std::map<lldb::pid_t, uint16_t> m_port_forwards;
     llvm::Optional<AdbClient::UnixSocketNamespace> m_socket_namespace;
 
     bool
     LaunchGDBServer (lldb::pid_t &pid, std::string &connect_url) override;
 

lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

if (error.Fail())
         return nullptr;
 
     return PlatformRemoteGDBServer::ConnectProcess(new_connect_url.c_str(),
                                                    plugin_name,
                                                    debugger,
                                                    target,
                                                    error);
 }
-
-size_t
-PlatformAndroidRemoteGDBServer::ConnectToWaitingProcesses(Debugger& debugger, Error& error)
-{
-    std::vector<std::string> connection_urls;
-    GetPendingGdbServerList(connection_urls);
-
-    for (size_t i = 0; i < connection_urls.size(); ++i)
-    {
-        ConnectProcess(connection_urls[i].c_str(), nullptr, debugger, nullptr, error);
-        if (error.Fail())
-            return i; // We already connected to i process succsessfully
-    }
-    return connection_urls.size();
-}

lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h

public:
 
     lldb::ProcessSP
     ConnectProcess (const char* connect_url,
                     const char* plugin_name,
                     lldb_private::Debugger &debugger,
                     lldb_private::Target *target,
                     lldb_private::Error &error) override;
 
+    size_t
+    ConnectToWaitingProcesses(lldb_private::Debugger& debugger, lldb_private::Error& error) override;
+
     virtual size_t
     GetPendingGdbServerList(std::vector<std::string>& connection_urls);
 
 protected:
     process_gdb_remote::GDBRemoteCommunicationClient m_gdb_client;
     std::string m_platform_description; // After we connect we can get a more complete description of what we are connected to
     std::string m_platform_scheme;
     std::string m_platform_hostname;

lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

PlatformRemoteGDBServer::ConnectProcess(const char* connect_url,
     {
         error.SetErrorString("Not connected to remote gdb server");
         return nullptr;
     }
     return Platform::ConnectProcess(connect_url, plugin_name, debugger, target, error);
 }
 
 size_t
+PlatformRemoteGDBServer::ConnectToWaitingProcesses(Debugger& debugger, Error& error)
+{
+    std::vector<std::string> connection_urls;
+    GetPendingGdbServerList(connection_urls);
+
+    for (size_t i = 0; i < connection_urls.size(); ++i)
+    {
+        ConnectProcess(connection_urls[i].c_str(), nullptr, debugger, nullptr, error);
+        if (error.Fail())
+            return i; // We already connected to i process succsessfully
+    }
+    return connection_urls.size();
+
+}
+
+size_t
 PlatformRemoteGDBServer::GetPendingGdbServerList(std::vector<std::string>& connection_urls)
 {
     std::vector<std::pair<uint16_t, std::string>> remote_servers;
     m_gdb_client.QueryGDBServer(remote_servers);
     for (const auto& gdbserver : remote_servers)
     {
         const char* socket_name_cstr = gdbserver.second.empty() ? nullptr : gdbserver.second.c_str();
         connection_urls.emplace_back(MakeGdbServerUrl(m_platform_scheme,
                                                       m_platform_hostname,
                                                       gdbserver.first,
                                                       socket_name_cstr));
     }
     return connection_urls.size();
 }