Page MenuHomePhabricator

[LLDB]{MIPS] Fix TestPlatformProcessConnect.py
ClosedPublic

Authored by nitesh.jain on Mar 11 2016, 5:04 AM.

Details

Summary

The patch http://reviews.llvm.org/D14952 which modifies the platform connect with automatically connecting to the process instance if it was started by the remote platform. However this fails for Linux Platform. Since PlatformRemoteGDBServer doesn't implement "ConnectToWaitingProcesses". Thus Platform::ConnectToWaitingProcesses was called and LLDB failed connecting to the remote process instance. This Patch implements "ConnectToWaitingProcesses" for PlatformRemoteGDBServer and hence fixes TestPlatformProcessConnect.py failure for linux Platform.

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain retitled this revision from to [LLDB]{MIPS] Fix TestPlatformProcessConnect.py.
nitesh.jain updated this object.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur and 2 others.
labath edited edge metadata.Mar 11 2016, 5:51 AM

If I understand correctly, you have simply copied the implementation from PlatformRemoteAndroidGDBServer. Could you also remove it from that class, since it's going to inherit the implementation anyway?

Apart from that, it looks good to me, but let's give a chance for @clayborg to respond first.

clayborg accepted this revision.Mar 11 2016, 9:21 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Mar 11 2016, 9:21 AM
nitesh.jain edited edge metadata.

Updated diff as per suggestion.

labath accepted this revision.Mar 14 2016, 2:52 AM
labath edited edge metadata.

Looks great. Thank you.

Hi Tamas Berghammer,

Is it ok to commit?

This revision was automatically updated to reflect the committed changes.