This is an archive of the discontinued LLVM Phabricator instance.

Make functions in altivec.h be inline.
ClosedPublic

Authored by djasper on Mar 9 2016, 3:02 PM.

Details

Reviewers
echristo
rsmith
Summary

Similar to other intrinsics these need to be inline to avoid ODR conflicts. Also, some of them seem to be always_inline which I think doesn't have an effect unless they are also inline.

I can also use clang-format on the patch, just thought I'd keep this easier to review for now.

Diff Detail

Event Timeline

djasper updated this revision to Diff 50203.Mar 9 2016, 3:02 PM
djasper retitled this revision from to Make functions in altivec.h be inline..
djasper updated this object.
djasper added a reviewer: rsmith.
djasper added a subscriber: cfe-commits.
echristo accepted this revision.Mar 11 2016, 2:00 PM
echristo edited edge metadata.

LGTM, nice catch Daniel.

(Yes, weird that nothing changed in the IR, but the patch is correct).

-eric

This revision is now accepted and ready to land.Mar 11 2016, 2:00 PM

Want me to run clang-format on the file/diff?

Since you're changing everything anyways? Sure why not! :)

-eric

djasper closed this revision.Mar 11 2016, 2:22 PM

Formatted and submitted as r263302.