This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Check the compiler version first
ClosedPublic

Authored by rnk on Mar 1 2016, 4:34 PM.

Details

Summary

Otherwise users get messages from CheckAtomic about missing libatomic
instead of a sensible message that says "use GCC 4.7 or newer".

I structured the change along the lines of HandleLLVMStdlib.cmake, which
I'm not sure I like. I'm open to suggestions on how to make sure we do
this check early in LLVM, and do it at some point in the standalone
clang build.

Diff Detail

Event Timeline

rnk updated this revision to Diff 49566.Mar 1 2016, 4:34 PM
rnk retitled this revision from to [cmake] Check the compiler version first.
rnk updated this object.
rnk added a reviewer: beanz.
rnk added a subscriber: llvm-commits.
beanz accepted this revision.Mar 2 2016, 8:39 AM
beanz edited edge metadata.

LGTM. One comment below to be addressed before commit.

cmake/modules/CheckCompilerVersion.cmake
2

The comment here says clang 3.2, but below you check for 3.1. We should make that consistent.

This revision is now accepted and ready to land.Mar 2 2016, 8:39 AM
This revision was automatically updated to reflect the committed changes.