This is an archive of the discontinued LLVM Phabricator instance.

Add complex and aggregate with vector types return value test cases
AcceptedPublic

Authored by omjavaid on Feb 29 2016, 5:49 AM.

Details

Reviewers
tberghammer
Summary

This patch adds tests to test complex return types and aggregate return types with vector elements.

Diff Detail

Event Timeline

omjavaid updated this revision to Diff 49365.Feb 29 2016, 5:49 AM
omjavaid retitled this revision from to Add complex and aggregate with vector types return value test cases.
omjavaid updated this object.
omjavaid added a reviewer: tberghammer.
omjavaid added a subscriber: lldb-commits.
tberghammer accepted this revision.Feb 29 2016, 6:13 AM
tberghammer edited edge metadata.

Looks good but please verify that the new test is passes on other architectures and XFAIL the test accordingly.

If you have to XFAIL something then I would prefer to split this test to smaller tests so we don't have to XFAIL everything just because of 1 check is failing

This revision is now accepted and ready to land.Feb 29 2016, 6:13 AM
labath requested changes to this revision.Feb 29 2016, 6:35 AM
labath added a reviewer: labath.
labath added a subscriber: labath.

I agree with Tamas here. Your previous patch also added a some tests here, which were breaking on some configurations (linux+gcc in this case). It's not a good idea no XFAIL the whole test just because of the added checks (which can be tested completely independently of the original test). If you don't want to refactor the existing checks, then please at least put the new checks (and the ones I just reverted) into a test of it's own.

Thanks.

This revision now requires changes to proceed.Feb 29 2016, 6:35 AM
labath resigned from this revision.Apr 20 2017, 6:13 AM
This revision is now accepted and ready to land.Apr 20 2017, 6:13 AM