This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Assembler: Check immediate types for several optional operands in predicate methods
ClosedPublic

Authored by SamWot on Feb 26 2016, 6:47 AM.

Details

Summary

With this change you should place optional operands in order specified by asm string:

  • clamp -> omod
  • offset -> glc -> slc -> tfe

Fixes for several tests.
Depends on D17568

Diff Detail

Event Timeline

SamWot updated this revision to Diff 49183.Feb 26 2016, 6:47 AM
SamWot retitled this revision from to [AMDGPU] Assembler: Check immediate types for several optional operands in predicate methods.
SamWot updated this object.
SamWot added reviewers: nhaustov, tstellarAMD.
SamWot added a subscriber: arsenm.
SamWot added a project: Restricted Project.Feb 26 2016, 6:48 AM
tstellarAMD accepted this revision.Feb 29 2016, 9:39 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 29 2016, 9:39 AM
nhaustov closed this revision.Mar 1 2016, 4:41 AM
nhaustov edited edge metadata.

r262314